This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Check and upgrade to latest scrypt release #17

Open

boughtonp opened this issue Sep 17, 2015 · 1 comment

Owner

boughtonp commented Sep 17, 2015

Check latest versions for official scrypt and Java port - identify current version & upgrade.

boughtonp added this to the v0.2 milestone

boughtonp mentioned this issue

Update jbcrypt to v0.4 #16

Closed

boughtonp removed this from the v0.2 milestone

Owner Author

boughtonp commented May 15, 2020

Already using latest wg/scrypt 1.4.0, which maps to Tarsnap/scrypt 1.1.6

Tarsnap/scrypt has three newer tagged versions (1.2.0, 1.2.1, 1.3.0) but:

the Tarsnap repo contains more than just the scrypt algorithm
there is excessive refactoring making the real changes hard to decipher

The only change I can see for sure is one to ensure that r and p (Memory cost and Parallelization) do not accept values of zero.

Two options for solving this issue:

Switch to using an updated fork of wg/scrypt - https://github.com/lhunath/scrypt appears to be most up to date. (It doesn't appear to have the zero checks, but does have other valid improvements to the code.)
Use a yescrypt implementation for scrypt support - yescrypt is a new algorithm that extends scrypt (and can generate standard scrypt hashes), but I've yet to find a Java implementation.

(Deferred from v0.2 to a later release.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.