networking: stack-overview: Correct some nits #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Benjamin <[email protected]>
Tropicao
reviewed
Jan 21, 2026
Contributor
Tropicao
left a comment
Tropicao
left a comment
There was a problem hiding this comment.
Hi @oli-ben , just adding a nit on your nit :D
I'll let the final word to @minimaxwell of course.
| \item Very technical topics | ||
| \item Usually single-day track on a multi-day event | ||
| \item LPC 2025 will be in Tôkyo, Japan, in December | ||
| \item LPC 2025 was in Tôkyo, Japan, in December |
Contributor
There was a problem hiding this comment.
I would even drop/replace this line. I feel like it is perfectly legitimate to cite LPC, but I would argue that citing specific editions generates content that will rot (eg, are we going to mention any future edition ?)
Contributor
There was a problem hiding this comment.
Truew let's remove the edition-specific part indeed
Contributor
Author
There was a problem hiding this comment.
OK! I'll also do that for NetDev, then!
Drop references to specific editions of LPC and NetDev. Signed-off-by: Olivier Benjamin <[email protected]>
Contributor
|
That's all fine for me, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few capitalization or plurals that I think might be good to drop.
Also, LPC 2025 is now in the past.