Makefile: Simplify agendas generation#305
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
If you rebase on top of the master branch the CLA bot should retrigger and not complain anymore (31d6c1a). |
Use a pattern rule for the agendas instead of a call to a sub-make, since the only prerequisite specific to an agenda can be expressed with a pattern. This fixes the parallel generation of the prerequisites of the agendas. Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
benoitmonin
force-pushed
the
make-agendas
branch
from
829e1a6 to
bfa92b7
Compare
|
This doesn't apply anymore since 8cc2671. Also, I'm not a big fan of the change in the first place as it breaks the pattern that we have for slides, labs and agendas. So if we want to avoid the sub-make, I'd prefer to avoid it for all cases, and not just for agendas. |
|
The goal would indeed be to drop the sub-make pattern, but it is hard to do so for slides & agendas. Which is why a first good step is to only change agendas. |
|
Well, I don't have the same reasoning. Until we have an idea to avoid the sub-make for everything, I prefer keeping the sub-make for everything. Consistency first. |
3 participants
Use a pattern rule for the agendas instead of a call to a sub-make, since the only prerequisite specific to an agenda can be expressed with a pattern.
This fixes the parallel generation of the prerequisites of the agendas.
Comparing the resulting pdfs with diff-pdf shows no difference.