Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to make threshold in get_cluster adaptive #1094

Open
barendgehrels opened this issue Nov 16, 2022 · 1 comment
Open

Try to make threshold in get_cluster adaptive #1094

barendgehrels opened this issue Nov 16, 2022 · 1 comment
Assignees
@barendgehrels
Labels
enhancement

Comments

@barendgehrels
Copy link
Collaborator

See issue #1081 and PR #1093
@barendgehrels barendgehrels self-assigned this Nov 16, 2022
@barendgehrels barendgehrels mentioned this issue Nov 16, 2022
Merged
@Mitsuhiko-Matsukawa
Copy link
Contributor

I have 83 cases that the difference of threshold (1 or 3) makes different result.
In some cases, 3 is better, the others, 1 is better.
These are the test codes.
get_culusters_1vs3.zip

I have tested them on Visual Studio 2019, debug, x64.
To avoid stack overflow, we need to set /STACK on MSVC linker options.
https://learn.microsoft.com/en-us/cpp/build/reference/stack-stack-allocations?view=msvc-170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barendgehrels barendgehrels

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barendgehrels @Mitsuhiko-Matsukawa