Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement editing functionality of all GeoLayers #296

Open
kb173 opened this issue Oct 19, 2022 · 4 comments
Open

Implement editing functionality of all GeoLayers #296

kb173 opened this issue Oct 19, 2022 · 4 comments
Labels
enhancement New feature or request limitation a known limitation

Comments

@kb173
Copy link
Member

kb173 commented Oct 19, 2022

We have these different GeoLayers which we want to edit:

  • Vector
    • Points
    • Lines
    • Polygons
  • Raster
    • RGB(A)
    • Float32
    • Byte

For Vector editing, we need to add points, move points, remove points, finish objects (e.g. stop the current line), and edit attributes.

For Raster editing, we want to change the value of pixels (to Color / number between 0 and 255 / any Float value). A color/value picker would also be useful. Different brushes would also be nice (size and fade-out).

@kb173 kb173 changed the title Define editing functionality of all GeoLayers Implement editing functionality of all GeoLayers Oct 19, 2022
@MathiasBaumgartinger
Copy link
Contributor

Implementation of #254 before doing this would be advisable.

@MathiasBaumgartinger
Copy link
Contributor

MathiasBaumgartinger commented Mar 22, 2023

A current exemplary implementation works as follows:

Image

f8d2160 implements a new - more generic - EditingAction and an ActionHandler. For each perspective an ActionHandler shall have three predifned actions: primary, secomdary, tertiary (mapping to e.g left, middle, right click). Each Perspective shall also have a duck typed equivalent of an AbstractCursor implementing certain functions. Furthermore EditingActions can be extended or used via special handle for additional cases.

36ab350 adds the input-map for 3D (primary -> left click, secondary -> right click, tertiary -> middle click)

278133f implements working functionality for GeoPoints. GeoPolygons and GeoLines seem to be currently limited by Geodot.

Working on RasterManagement next.

@MathiasBaumgartinger MathiasBaumgartinger added enhancement New feature or request limitation a known limitation labels Mar 22, 2023
@MathiasBaumgartinger
Copy link
Contributor

@kb173
Copy link
Member Author

kb173 commented Aug 2, 2023

Raster editing is also related to boku-ilen/geodot-plugin#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limitation a known limitation
Projects
None yet
Development

No branches or pull requests

2 participants