Skip to content

Commit 585ade9

Browse files
committed
#42 Preferences updated whether text is selected or not
1 parent 842644d commit 585ade9

File tree

3 files changed

+24
-23
lines changed

3 files changed

+24
-23
lines changed

lib/Chrome.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ exports.selectDir = function(selectedText) {
2525

2626
Preference.set("pathToFile", fp.file.path);
2727
Panel.show(selectedText);
28-
}
28+
};
2929
}
3030

3131
function createFileObject(saveDirectory, fileName) {
3232

3333
var currentTime = new Date(),
34-
date,
34+
date = '',
3535
time = currentTime.getHours() + "-" + currentTime.getMinutes() + "-" + currentTime.getSeconds();
3636

3737
//create date format based on user's preference
@@ -91,7 +91,7 @@ exports.saveTo = function(selectedText){
9191
var ostream,
9292
string = '\n\n',
9393
currentTime = new Date(),
94-
date,
94+
date = '',
9595
time = currentTime.getHours() + "-" + currentTime.getMinutes() + "-" + currentTime.getSeconds(),
9696
file = createFileObject(Preference.get('pathToFile'), filename);
9797

lib/Panel.js

+20-19
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,25 @@ exports.init = function() {
2626

2727
panel.port.on("save", function (selectedPrefs) {
2828

29+
var parsedPerfs = JSON.parse(selectedPrefs);
30+
31+
Preference.set('fileName', parsedPerfs.fileName);
32+
Preference.set('pathToFile', parsedPerfs.pathToFile);
33+
Preference.set('datestamp', parsedPerfs.datestamp);
34+
Preference.set('timestamp', parsedPerfs.timestamp);
35+
Preference.set('datestampInLine', parsedPerfs.datestampInLine);
36+
Preference.set('timestampInLine', parsedPerfs.timestampInLine);
37+
Preference.set('dateFormat', parseInt(parsedPerfs.dateFormat));
38+
Preference.set('lineSeparator', parsedPerfs.lineSeparator);
39+
Preference.set('currentURL', parsedPerfs.currentURL);
40+
Preference.set('pagenameForFilename', parsedPerfs.pagenameForFilename);
41+
Preference.set('saveMode', parseInt(parsedPerfs.saveMode));
42+
Preference.set('confirmPanel', parsedPerfs.confirmPanel);
43+
Preference.set('showWidget', parsedPerfs.showWidget);
44+
Preference.set('showNotifications', parsedPerfs.showNotifications);
45+
46+
47+
2948
if(selectedText === "" || selectedText === null){
3049

3150
if (Preference.get('showNotifications')){
@@ -35,25 +54,7 @@ exports.init = function() {
3554

3655
panel.hide();
3756

38-
}else{
39-
40-
var parsedPerfs = JSON.parse(selectedPrefs);
41-
42-
Preference.set('fileName', parsedPerfs.fileName);
43-
Preference.set('pathToFile', parsedPerfs.pathToFile);
44-
Preference.set('datestamp', parsedPerfs.datestamp);
45-
Preference.set('timestamp', parsedPerfs.timestamp);
46-
Preference.set('datestampInLine', parsedPerfs.datestampInLine);
47-
Preference.set('timestampInLine', parsedPerfs.timestampInLine);
48-
Preference.set('dateFormat', parseInt(parsedPerfs.dateFormat));
49-
Preference.set('lineSeparator', parsedPerfs.lineSeparator);
50-
Preference.set('currentURL', parsedPerfs.currentURL);
51-
Preference.set('pagenameForFilename', parsedPerfs.pagenameForFilename);
52-
Preference.set('saveMode', parseInt(parsedPerfs.saveMode));
53-
Preference.set('confirmPanel', parsedPerfs.confirmPanel);
54-
Preference.set('showWidget', parsedPerfs.showWidget);
55-
Preference.set('showNotifications', parsedPerfs.showNotifications);
56-
57+
}else{
5758

5859
Chrome.saveTo(selectedText);
5960
panel.hide();

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"description": "Saves highlighted text to a file in a specified directory",
66
"author": "Robert Byrne",
77
"license": "GNU GPL v3",
8-
"version": "2.1.10",
8+
"version": "2.1.11",
99
"permissions": {"private-browsing": true},
1010
"preferences": [{
1111
"name": "fileName",

0 commit comments

Comments
 (0)