Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boa to Test262-Harness #3431

Open
1 of 4 tasks
jasonwilliams opened this issue Oct 29, 2023 · 5 comments
Open
1 of 4 tasks

Add Boa to Test262-Harness #3431

jasonwilliams opened this issue Oct 29, 2023 · 5 comments
Labels
E-Easy Easy enhancement New feature or request good first issue Good for newcomers test Issues and PRs related to the tests.

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Oct 29, 2023

Boa being part of Test262-Harness will make it easier to test which parts of TEST262 Boa has implemented. Currently it's not easy to do this. There are a few dependencies Boa needs to be added to before this can happen.

Test262-harness uses eshost which uses esvu. Boa support would need to be added to these repositories.

@jasonwilliams jasonwilliams added enhancement New feature or request test Issues and PRs related to the tests. good first issue Good for newcomers E-Easy Easy labels Oct 29, 2023
@linusg
Copy link
Contributor

linusg commented Jul 12, 2024

Upstream eshost and test262-harness are effectively unmaintained, so test262.fyi uses these two forks:

@CanadaHonk added boa support to the eshost fork, test262-harness doesn't need any additional changes.

@jasonwilliams
Copy link
Member Author

This is good to know and thanks for adding Boa to these forks.

My concern though is that the TC39 champions are still using the original version. Last time I spoke to Temporal champions they were using Brian’s harness, it’s also listed here on the test262 page. https://github.com/tc39/test262?tab=readme-ov-file#test262-runners

Is it possible to make @CanadaHonk’s version the canonical version by asking on there? Or I can ask if you don’t want to. We should just have everyone use this one if it’s more actively maintained

@CanadaHonk
Copy link

Fwiw, I haven't fully tried to get my changes upstream as those were originally mostly intended as a fork for test262.fyi specifically before I knew upstream was inactive. I believe they are still usable standalone like the original though, so I'm happy for my forks to become canonical if wanted.

@jasonwilliams
Copy link
Member Author

For what it’s worth, I don’t think it makes sense to even try upstreaming your changes at this point. The upstream version hasn’t been maintained in years and Brian isn’t as active as he was before either.

Effort is better spent moving to your version (updating docs etc), but that’s just my opinion.

@jasonwilliams
Copy link
Member Author

Upstream eshost and test262-harness are effectively unmaintained, so test262.fyi uses these two forks:

@CanadaHonk added boa support to the eshost fork, test262-harness doesn't need any additional changes.

Does Boa need adding to the readme if it’s supported in https://github.com/CanadaHonk/eshost ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Easy Easy enhancement New feature or request good first issue Good for newcomers test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants