Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-module deploy time configuration #26

Open
ahal opened this issue Jan 16, 2023 · 1 comment
Open

Per-module deploy time configuration #26

ahal opened this issue Jan 16, 2023 · 1 comment

Comments

@ahal
Copy link
Contributor

ahal commented Jan 16, 2023

It may be desirable to configure some modules at deploy time, e.g to add credentials, support defaults or tweak the behaviour of the module. While it's currently possible to do this via the !admin module (see mastodon module for example), this isn't very convenient and the configuration is lost if the store is ever removed.

Instead, it would be nice if there existed some config file which could set arbitrary configuration per-module. Trinity would then pass the configuration for a specific module into that module on initial load. The modules would be responsible for taking care of the rest.

@bnjbvr
Copy link
Owner

bnjbvr commented Jan 16, 2023

Makes sense to me. If we implement this, it would be nice if it could be kept optional (i.e. doesn't crash the entire program if the configuration file is not there -- so it might be an optional command line argument or something like that). I like that the !admin module basically allows saving state at runtime, so I don't have to share secrets publicly in configuration files (speaking thereof... toml files, maybe?). If you're interested in implementing this, go ahead, I'm happy to review this later.

ahal added a commit to ahal/trinity that referenced this issue Feb 11, 2023
ahal added a commit to ahal/trinity that referenced this issue Mar 20, 2023
ahal added a commit to ahal/trinity that referenced this issue May 30, 2023
ahal added a commit to ahal/trinity that referenced this issue May 31, 2023
ahal added a commit to ahal/trinity that referenced this issue Jun 6, 2023
ahal added a commit to ahal/trinity that referenced this issue Jun 6, 2023
bnjbvr pushed a commit to ahal/trinity that referenced this issue Jun 24, 2023
bnjbvr pushed a commit that referenced this issue Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants