Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't reject invalid quantiles #17

Open
carbocation opened this issue Sep 3, 2017 · 0 comments
Open

Doesn't reject invalid quantiles #17

carbocation opened this issue Sep 3, 2017 · 0 comments

Comments

@carbocation
Copy link

Due to PBKAC, I was inputting quantiles such as []float64{1, 10, 50, 90, 99} rather than []float64{0.01, 0.1, 0.5, 0.9, 0.99}. The program was crashing due to index out of range errors triggered in quantile.(*Stream).Query(), which seems less obvious to me than to receive an error that indicates that my requested quantiles were invalid. There aren't errors returned by NewTargeted() or by Query(), so the changes that seem obvious to me would be API-breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant