Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure monitors should be editable #1277

Open
gorkem-bwl opened this issue Dec 4, 2024 · 5 comments
Open

Infrastructure monitors should be editable #1277

gorkem-bwl opened this issue Dec 4, 2024 · 5 comments
Assignees
@vishnusn77
Labels
frontend good first issue Good for newcomers
Milestone
2.1 (Ship of Thes...

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Dec 4, 2024 •
edited
Loading

Currently an infra monitor cannot be edited. We need to apply the same methodology we use in "Monitors" section. We can add a "Configure" button in details section of an infra monitor so the end user can edit and save again.

Here is a sample screenshot showing where the Configure button is (this is for the monitors section and you can apply the same method to the Infrastructure section):

image
@gorkem-bwl gorkem-bwl added good first issue Good for newcomers frontend labels Dec 4, 2024
@gorkem-bwl gorkem-bwl added this to the 2.1 milestone Dec 4, 2024
@peterpardo
Copy link
Contributor

Hello! I can work on this.

@gorkem-bwl
Copy link
Contributor Author

Sure, go ahead. Please check how it is implemented in Monitors section. Have a look at that area and check the behaviour as well. Also, attach a video when you are done.

Thank you.

@gorkem-bwl gorkem-bwl modified the milestones: 2.1, 2.0.1 Dec 6, 2024
@gorkem-bwl
Copy link
Contributor Author

gorkem-bwl commented Dec 6, 2024 •
edited
Loading

FYI @peterpardo this will go into 2.0.1 minor release.

@peterpardo peterpardo mentioned this issue Dec 6, 2024
Closed
@gorkem-bwl gorkem-bwl modified the milestones: 2.0.1, 2.0.2, 2.1 Jan 19, 2025
@gorkem-bwl gorkem-bwl mentioned this issue Feb 5, 2025
Open
@ajhollid ajhollid assigned ajhollid and unassigned peterpardo Feb 24, 2025
@vishnusn77 vishnusn77 self-assigned this Feb 25, 2025
@gorkem-bwl gorkem-bwl changed the title Infratructure monitors should be editable Infrastructure monitors should be editable Feb 26, 2025
@gorkem-bwl
Copy link
Contributor Author

@vishnusn77 we can get this to the 2.1 release, what do you think?

@vishnusn77
Copy link
Contributor

@vishnusn77 we can get this to the 2.1 release, what do you think?

@gorkem-bwl Sure, we can do that. I'm currently working on this.

@vishnusn77 vishnusn77 mentioned this issue Mar 15, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishnusn77 vishnusn77

Labels
frontend good first issue Good for newcomers
Projects
None yet
Milestone
2.1 (Ship of Theseus)
Development

Successfully merging a pull request may close this issue.

feat: Edit infrastructure monitor page peterpardo/checkmate
4 participants
@ajhollid @peterpardo @vishnusn77 @gorkem-bwl