New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the HighWaterMarkLocationKey structs #321

Open

pablogsal opened this issue Feb 21, 2023 · 0 comments

Labels

Milestone

Member

pablogsal commented Feb 21, 2023

See

memray/src/memray/_memray/snapshot.h

Lines 237 to 240 in 63d31d5

    
           // Like LocationKey, but considers the native_segment_generation and the 
        
           // allocator to be part of the key. Arguably it's a bug that LocationKey 
        
           // doesn't, for each of these. For now, I'm defining a separate type to avoid 
        
           // scope creep, but we should merge these.

pablogsal added this to the Q1 2023 milestone

pablogsal added the enhancement label

pablogsal mentioned this issue

Temporal flamegraphs #317

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment