Adapt to Textual 0.87.1

The new textual release has some changes: * We need to change how our tests get the rendered version of some Textual objects as now `render()` returns `RichVisual` instances. * Textual has a new theme so we need to regenerate our snapshots. * There was a regression in how focusing a widget while the app is still starting up behaves. This has been fixed upstream in Textualize/textual#5284 but our snapshots will not pass until the fix makes it into a release. Signed-off-by: Matt Wozniski <[email protected]>
bloomberg · Nov 27, 2024 · 85087fc · 85087fc
1 parent beea5cd
commit 85087fc
Show file tree

Hide file tree

Showing 23 changed files with 2,360 additions and 2,405 deletions.
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -5,7 +5,7 @@
 from packaging import version
 
 SNAPSHOT_MINIMUM_VERSIONS = {
-    "textual": "0.81",
+    "textual": "0.87.1",
     "pytest-textual-snapshot": "1.0",
 }
 

diff --git a/...shots__/test_tree_reporter/TestTUILooks.test_allocations_of_different_sizes.svg b/...shots__/test_tree_reporter/TestTUILooks.test_allocations_of_different_sizes.svg
diff --git a/tests/unit/__snapshots__/test_tree_reporter/TestTUILooks.test_basic.svg b/tests/unit/__snapshots__/test_tree_reporter/TestTUILooks.test_basic.svg
diff --git a/...__snapshots__/test_tree_reporter/TestTUILooks.test_basic_node_selected_leaf.svg b/...__snapshots__/test_tree_reporter/TestTUILooks.test_basic_node_selected_leaf.svg
diff --git a/...apshots__/test_tree_reporter/TestTUILooks.test_basic_node_selected_not_leaf.svg b/...apshots__/test_tree_reporter/TestTUILooks.test_basic_node_selected_not_leaf.svg
diff --git a/...unit/__snapshots__/test_tree_reporter/TestTUILooks.test_biggest_allocations.svg b/...unit/__snapshots__/test_tree_reporter/TestTUILooks.test_biggest_allocations.svg
diff --git a/.../unit/__snapshots__/test_tree_reporter/TestTUILooks.test_hide_import_system.svg b/.../unit/__snapshots__/test_tree_reporter/TestTUILooks.test_hide_import_system.svg
diff --git a/tests/unit/__snapshots__/test_tree_reporter/TestTUILooks.test_select_screen.svg b/tests/unit/__snapshots__/test_tree_reporter/TestTUILooks.test_select_screen.svg
diff --git a/.../unit/__snapshots__/test_tree_reporter/TestTUILooks.test_show_uninteresting.svg b/.../unit/__snapshots__/test_tree_reporter/TestTUILooks.test_show_uninteresting.svg
diff --git a/...t_tree_reporter/TestTUILooks.test_show_uninteresting_and_hide_import_system.svg b/...t_tree_reporter/TestTUILooks.test_show_uninteresting_and_hide_import_system.svg
diff --git a/tests/unit/__snapshots__/test_tree_reporter/TestTUILooks.test_two_chains.svg b/tests/unit/__snapshots__/test_tree_reporter/TestTUILooks.test_two_chains.svg
diff --git a/...ts__/test_tree_reporter/TestTUILooks.test_two_chains_after_expanding_second.svg b/...ts__/test_tree_reporter/TestTUILooks.test_two_chains_after_expanding_second.svg
diff --git a/tests/unit/__snapshots__/test_tui_reporter/test_merge_threads.svg b/tests/unit/__snapshots__/test_tui_reporter/test_merge_threads.svg
diff --git a/...st_tui_reporter/test_tui_basic[narrow-terminal-focus-header-long-snapshots].svg b/...st_tui_reporter/test_tui_basic[narrow-terminal-focus-header-long-snapshots].svg
diff --git a/...apshots__/test_tui_reporter/test_tui_basic[narrow-terminal-short-snapshots].svg b/...apshots__/test_tui_reporter/test_tui_basic[narrow-terminal-short-snapshots].svg
diff --git a/...hots__/test_tui_reporter/test_tui_basic[very-wide-terminal-short-snapshots].svg b/...hots__/test_tui_reporter/test_tui_basic[very-wide-terminal-short-snapshots].svg
diff --git a/..._snapshots__/test_tui_reporter/test_tui_basic[wide-terminal-long-snapshots].svg b/..._snapshots__/test_tui_reporter/test_tui_basic[wide-terminal-long-snapshots].svg
diff --git a/tests/unit/__snapshots__/test_tui_reporter/test_tui_gradient.svg b/tests/unit/__snapshots__/test_tui_reporter/test_tui_gradient.svg
diff --git a/...t/__snapshots__/test_tui_reporter/test_tui_pause[narrow-terminal-connected].svg b/...t/__snapshots__/test_tui_reporter/test_tui_pause[narrow-terminal-connected].svg
diff --git a/..._snapshots__/test_tui_reporter/test_tui_pause[narrow-terminal-disconnected].svg b/..._snapshots__/test_tui_reporter/test_tui_pause[narrow-terminal-disconnected].svg
diff --git a/tests/unit/__snapshots__/test_tui_reporter/test_tui_pause[wider-terminal].svg b/tests/unit/__snapshots__/test_tui_reporter/test_tui_pause[wider-terminal].svg
diff --git a/tests/unit/__snapshots__/test_tui_reporter/test_unmerge_threads.svg b/tests/unit/__snapshots__/test_tui_reporter/test_unmerge_threads.svg
diff --git a/tests/unit/test_tui_reporter.py b/tests/unit/test_tui_reporter.py
@@ -140,7 +140,7 @@ async def run_before_wrapper(pilot) -> None:
 
 def render_widget(widget: Widget) -> str:
     output = StringIO()
-    rprint(widget.render(), file=output)
+    rprint(widget.renderable, file=output)
     return output.getvalue()