fixup! fixup! Alternative design 2

Author: pablogsal

src/memray/reporters/tree.py

@@ -11,14 +11,16 @@
 from typing import Optional
 from typing import Tuple
 
-from textual import events
 from textual.app import App
-from textual import log
 from textual.app import ComposeResult
 from textual.binding import Binding
-from textual.containers import Grid, Container
+from textual.containers import Container
+from textual.containers import Grid
+from textual.containers import Horizontal
+from textual.containers import Vertical
 from textual.dom import DOMNode
-from textual.screen import ModalScreen
+from textual.reactive import reactive
+from textual.widget import Widget
 from textual.widgets import Footer
 from textual.widgets import Label
 from textual.widgets import ListItem
@@ -27,10 +29,6 @@
 from textual.widgets import Tree
 from textual.widgets._text_area import Edit
 from textual.widgets.tree import TreeNode
-from textual.containers import Horizontal, Vertical
-from textual.reactive import reactive
-from textual.widget import Widget
-
 
 from memray import AllocationRecord
 from memray._memray import size_fmt
@@ -66,15 +64,19 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         super().__init__(*args, **kwargs)
         self.cursor_blink = False
 
+    def edit(self, edit: Edit) -> Any:
+        return
+
+
 class FrameDetailScreen(Widget):
     """A screen that displays information about a frame"""
 
-    frame = reactive(None)
+    frame = reactive(Frame(location=ROOT_NODE, value=0))
 
     def __init__(self, *args: Any, **kwargs: Any) -> None:
         super().__init__(*args, **kwargs)
         self.is_mounted = False
-    
+
     def on_mount(self) -> None:
         self.is_mounted = True
 
@@ -86,14 +88,20 @@ def watch_frame(self) -> None:
         text = self.query_one("#textarea", FrozenTextArea)
         delta = text.size.height // 2
         lines = linecache.getlines(file)[line - delta : line + delta]
- 
+
         self.query_one("#function", Label).update(f":compass: Function: {function}")
         self.query_one("#location", Label).update(f":compass: Location: {file}:{line}")
-        self.query_one("#allocs", Label).update(f":floppy_disk: Allocations: {self.frame.n_allocations}")
-        self.query_one("#size", Label).update(f":package: Size: {size_fmt(self.frame.value)}")
-        self.query_one("#thread", Label).update(f":thread: Thread: {self.frame.thread_id}")
+        self.query_one("#allocs", Label).update(
+            f":floppy_disk: Allocations: {self.frame.n_allocations}"
+        )
+        self.query_one("#size", Label).update(
+            f":package: Size: {size_fmt(self.frame.value)}"
+        )
+        self.query_one("#thread", Label).update(
+            f":thread: Thread: {self.frame.thread_id}"
+        )
         text.text = "\n".join(tuple(line.rstrip() for line in lines))
-        text.select_line((delta-1))
+        text.select_line((delta - 1))
         text.show_line_numbers = False
 
     def compose(self) -> ComposeResult:
@@ -113,21 +121,31 @@ def compose(self) -> ComposeResult:
                 ListItem(Label(f":compass: Function: {function}", id="function")),
                 ListItem(Label(f":compass: Location: {file}:{line}", id="location")),
                 ListItem(
-                    Label(f":floppy_disk: Allocations: {self.frame.n_allocations}", id="allocs")
+                    Label(
+                        f":floppy_disk: Allocations: {self.frame.n_allocations}",
+                        id="allocs",
+                    )
+                ),
+                ListItem(
+                    Label(f":package: Size: {size_fmt(self.frame.value)}", id="size")
+                ),
+                ListItem(
+                    Label(f":thread: Thread: {self.frame.thread_id}", id="thread")
                 ),
-                ListItem(Label(f":package: Size: {size_fmt(self.frame.value)}", id="size")),
-                ListItem(Label(f":thread: Thread: {self.frame.thread_id}", id="thread")),
             ),
             id="node",
         )
 
+
 class FrameTree(Tree[Frame]):
-    def on_tree_node_selected(self, node: Tree.NodeSelected) -> None:
-        self.app.query_one(FrameDetailScreen).frame = node.node.data
-    
-    def on_tree_node_highlighted(self, node: Tree.NodeHighlighted) -> None:
-        self.app.query_one(FrameDetailScreen).frame = node.node.data
-    
+    def on_tree_node_selected(self, node: Tree.NodeSelected[Frame]) -> None:
+        if node.node.data is not None:
+            self.app.query_one(FrameDetailScreen).frame = node.node.data
+
+    def on_tree_node_highlighted(self, node: Tree.NodeHighlighted[Frame]) -> None:
+        if node.node.data is not None:
+            self.app.query_one(FrameDetailScreen).frame = node.node.data
+
 
 class TreeApp(App[None]):
     BINDINGS = [
@@ -174,9 +192,7 @@ def compose(self) -> ComposeResult:
             Vertical(
                 Container(tree, id="treec"),
             ),
-            Vertical(
-                FrameDetailScreen()
-            ),
+            Vertical(FrameDetailScreen()),
         )
         yield Footer()
 
@@ -190,7 +206,6 @@ def action_expand_linear_group(self) -> None:
                 break
             current_node = current_node.children[0]
 
-
     def create_tree(
         self,
         node: Frame,