emacs-lsp-booster doesn't work well with emacs-pet/pyvenv regarding python virtual environment #37
Comments
|
Thanks for the very detailed report. Going though your log, I think the different may come from this: vs This client notification sends the virtual env path to the server. If this step goes wrong, it may explain what you experienced. According to the log, when I don't think the |
|
No,
|
|
Thanks for your comment, I've CCed this issue to the author of pet, @jdtsmith would you like to share your workflow with |
|
In the end you just need to set |
|
When an empty hash table is sent in What do you see from How exactly do you enable |
|
Not special, magical step to enable
(use-package eglot-booster
:after eglot
:config (eglot-booster-mode))
|
|
I can't reproduce this issue on Emacs 30. All 3 packages works totally fine together. Are you able to reprod the same issue using the latest eglot from Elpa? You appear to be using the bundled eglot in Emacs 29. |
|
Thanks for your heads-up, after installing
|
|
I encountered this problem again even though I've upgraded (defun ramsay/pyrightconfig-find-venv-directories (project-root)
"Find potential virtual environment directories for a project in PROJECT-ROOT."
(let* ((common-venv-names '(".venv" ".env" "venv" "env"))
(common-venv-locations (list project-root))
(potential-paths '()))
;; Check common locations in project root and home directory
(dolist (location common-venv-locations)
(dolist (name common-venv-names)
(let ((full-path (expand-file-name name location)))
(when (file-directory-p full-path)
(push full-path potential-paths)))))
;; Return found paths
(reverse potential-paths)))
(defun ramsay/pyrightconfig-suggest ()
"Interactively select a virtualenv and write pyrightconfig.json."
(interactive)
(let* ((project-root (or (vc-git-root default-directory)
default-directory))
(venv-paths (ramsay/pyrightconfig-find-venv-directories project-root))
(selected-venv
(completing-read
"Select virtual environment: "
(append venv-paths
;; Add option to specify custom path
'("[Custom path...]"))
nil t)))
(if (string= selected-venv "[Custom path...]")
;; If custom path selected, call original function
(call-interactively #'ramsay/pyrightconfig-write)
;; Otherwise use selected path
(ramsay/pyrightconfig-write selected-venv))))
;; Derived from https://robbmann.io/posts/emacs-eglot-pyrightconfig/
(defun ramsay/pyrightconfig-write (virtualenv)
"Write pyrightconfig.json for the given VIRTUALENV path."
(interactive "DEnv: ")
(let* ((venv-dir (tramp-file-local-name (file-truename virtualenv)))
(venv-file-name (directory-file-name venv-dir))
(venvPath (file-name-directory venv-file-name))
(venv (file-name-base venv-file-name))
(base-dir (vc-git-root default-directory))
(out-file (expand-file-name "pyrightconfig.json" base-dir))
(out-contents (json-encode (list :venvPath venvPath :venv venv))))
(with-temp-file out-file (insert out-contents))))https://github.com/ramsayleung/emacs.d/blob/master/lisp/init-programming.el#L97-L144 |
|
I do something like that too, but I have eglot send it to pyright "over the wire" to keep all config in emacs. Something like: (defun my/eglot-workspace-config (server)
"A workspace config for pyright/basedpyright.
Note that some settings do not nest as you'd expect. Allows
dir-local special config variable `pyright-extra-paths' to be
added via `:extraPaths`.'"
(let ((config (list :python.analysis ; N.B. eglot does not consider :settings nested!
;; (list :diagnosticMode "openFilesOnly")
(list :stubPath
(expand-file-name "~/code/python/stubs/common")
;; :diagnosticMode "openFilesOnly"
)
;; recommended is TMI IMO
:basedpyright.analysis '(:typeCheckingMode "standard"))))
(hack-dir-local-variables-non-file-buffer)
(when (bound-and-true-p pyright-extra-paths)
(setf (plist-get (cadr config) :extraPaths)
(vconcat pyright-extra-paths)))
(when-let ((venv (simple-venv-find)) ; this command is local to my config
((not (eq venv 'none)))
(vp (file-name-directory venv))
(vn (file-name-nondirectory venv)))
(nconc config
(list :python `(;; :venvPath ,vp :venv ,vn
:pythonPath ,(simple-venv-interpreter venv)))))
config)) |
Hi, Thanks so much for this awsome project, it works well with all language servers along with
eglot, except for python project with virtual environment in my case.I used to manage my virual environment with
https://github.com/jorgenschaefer/pyvenv, then switch topetlater.But I've been struggled with
eglot-booster-modefor a while, after I enableeglot-booster-modewithpet,eglotfails to recognize all dependencies installed in the virtual environment.How to reproduce
pyright-language-serveris installed and in your PATHpython3 -m venv .venv source .venv/bin/activate pip install python-dotenvinit.elOpen the
poc.pywith(eglot-booster-mode)enabled, flymake couldn't resolve thedotenvpackageReopen the
poc.pywith(eglot-booster-mode)disabled, restarteglotor restart emacs, flymake manages to resolve thedotenvLogs
eglot-booster-modeenabled:eglot-booster-modedisabled:The text was updated successfully, but these errors were encountered: