Add never save option to password dialog

minbrowser#1549

Author: PalmerAL

css/passwordCapture.css

@@ -51,6 +51,22 @@
   background: rgba(255, 255, 255, 0.15);
 }
 
+#password-capture-never-save {
+  padding: 0.33em 1em;
+  font-size: 14px;
+  position: absolute;
+  right: 0.75em;
+  top: 50%;
+  transform: translateY(-50%);
+  height: 2em;
+}
+
+@media all and (max-width: 1065px) {
+  #password-capture-never-save {
+    display: none
+  }
+}
+
 #password-capture-username {
   margin-right: 0.5em;
 }

css/passwordViewer.css

@@ -27,6 +27,12 @@
   min-width: 0;
 }
 
+#password-viewer-list > div > span.description {
+  flex: 1;
+  opacity: 0.9;
+  font-style: italic;
+}
+
 #password-viewer .domain-name {
   width: 30%;
   overflow: hidden;

index.html

@@ -302,6 +302,10 @@ <h3 class="modal-title" id="manager-setup-heading"></h3>
           data-string="passwordCaptureDontSave"
         ></button>
       </span>
+      <button
+      id="password-capture-never-save"
+      data-string="passwordCaptureNeverSave"
+      ></button>
     </div>
 
     <div id="password-viewer" class="modal" hidden>

js/passwordManager/passwordCapture.js

@@ -1,4 +1,5 @@
 const webviews = require('webviews.js')
+const settings = require('util/settings/settings.js')
 const PasswordManagers = require('passwordManager/passwordManager.js')
 
 const passwordCapture = {
@@ -8,6 +9,7 @@ const passwordCapture = {
   passwordInput: document.getElementById('password-capture-password'),
   revealButton: document.getElementById('password-capture-reveal-password'),
   saveButton: document.getElementById('password-capture-save'),
+  neverSaveButton: document.getElementById('password-capture-never-save'),
   closeButton: document.getElementById('password-capture-ignore'),
   currentDomain: null,
   barHeight: 0,
@@ -50,6 +52,10 @@ const passwordCapture = {
       domain = domain.slice(4)
     }
 
+    if (settings.get('passwordsNeverSaveDomains') && settings.get('passwordsNeverSaveDomains').includes(domain)) {
+      return
+    }
+
     var username = args[0][1] || ''
     var password = args[0][2] || ''
 
@@ -89,6 +95,11 @@ const passwordCapture = {
       }
     })
 
+    passwordCapture.neverSaveButton.addEventListener('click', function () {
+      settings.set('passwordsNeverSaveDomains', (settings.get('passwordsNeverSaveDomains') || []).concat([passwordCapture.currentDomain]))
+      passwordCapture.hideCaptureBar()
+    })
+
     passwordCapture.closeButton.addEventListener('click', passwordCapture.hideCaptureBar)
     passwordCapture.revealButton.addEventListener('click', passwordCapture.togglePasswordVisibility)
 

js/passwordManager/passwordViewer.js

@@ -1,4 +1,5 @@
 const webviews = require('webviews.js')
+const settings = require('util/settings/settings.js')
 const PasswordManagers = require('passwordManager/passwordManager.js')
 const modalMode = require('modalMode.js')
 
@@ -56,6 +57,30 @@ const passwordViewer = {
 
     return container
   },
+  createNeverSaveDomainElement: function (domain) {
+    var container = document.createElement('div')
+
+    var domainEl = document.createElement('span')
+    domainEl.className = 'domain-name'
+    domainEl.textContent = domain
+    container.appendChild(domainEl)
+
+    var descriptionEl = document.createElement('span')
+    descriptionEl.className = 'description'
+    descriptionEl.textContent = l('savedPasswordsNeverSavedLabel')
+    container.appendChild(descriptionEl)
+
+    var deleteButton = document.createElement('button')
+    deleteButton.className = 'i carbon:trash-can'
+    container.appendChild(deleteButton)
+
+    deleteButton.addEventListener('click', function () {
+      settings.set('passwordsNeverSaveDomains', settings.get('passwordsNeverSaveDomains').filter(d => d !== domain))
+      container.remove()
+    })
+
+    return container
+  },
   show: function () {
     PasswordManagers.getConfiguredPasswordManager().then(function (manager) {
       if (!manager.getAllCredentials) {
@@ -73,7 +98,13 @@ const passwordViewer = {
           passwordViewer.listContainer.appendChild(passwordViewer.createCredentialListElement(cred))
         })
 
-        passwordViewer.emptyHeading.hidden = (credentials.length !== 0)
+        const neverSaveDomains = settings.get('passwordsNeverSaveDomains') || []
+
+        neverSaveDomains.forEach(function (domain) {
+          passwordViewer.listContainer.appendChild(passwordViewer.createNeverSaveDomainElement(domain))
+        })
+
+        passwordViewer.emptyHeading.hidden = (credentials.length + neverSaveDomains.length !== 0)
       })
     })
   },

localization/languages/ar.json

@@ -261,9 +261,11 @@
     "passwordCaptureSavePassword": null, //missing translation
     "passwordCaptureSave": null, //missing translation
     "passwordCaptureDontSave": null, //missing translation
+    "passwordCaptureNeverSave": null, //missing translation
     /* Password viewer */
     "savedPasswordsHeading": null, //missing translation
     "savedPasswordsEmpty": null, //missing translation
+    "savedPasswordsNeverSavedLabel": null, //missing translation
     "deletePassword": null, //missing translation
     /* Dialogs */
     "loginPromptTitle": null, //missing translation

localization/languages/bg.json

@@ -264,9 +264,11 @@
     "passwordCaptureSavePassword": "Запази парола за %s?",
     "passwordCaptureSave": "Запази",
     "passwordCaptureDontSave": "Не запазвай",
+    "passwordCaptureNeverSave": null, //missing translation
     /* Password viewer */
     "savedPasswordsHeading": "Запазени пароли",
     "savedPasswordsEmpty": "Няма запазени пароли.",
+    "savedPasswordsNeverSavedLabel": null, //missing translation
     "deletePassword": "Изтрий парола за %s?",
     /* Dialogs */
     "loginPromptTitle": "Впишете се в %h (%r)", //%h is replaced with host, %r with realm (title of protected part of site)

localization/languages/bn.json

@@ -261,9 +261,11 @@
     "passwordCaptureSavePassword": null, //missing translation
     "passwordCaptureSave": null, //missing translation
     "passwordCaptureDontSave": null, //missing translation
+    "passwordCaptureNeverSave": null, //missing translation
     /* Password viewer */
     "savedPasswordsHeading": null, //missing translation
     "savedPasswordsEmpty": null, //missing translation
+    "savedPasswordsNeverSavedLabel": null, //missing translation
     "deletePassword": null, //missing translation
     /* Dialogs */
     "loginPromptTitle": null, //missing translation

localization/languages/cs.json

@@ -265,9 +265,11 @@
     "passwordCaptureSavePassword": "Uložit heslo pro %s?",
     "passwordCaptureSave": "Uložit",
     "passwordCaptureDontSave": "Neukládat",
+    "passwordCaptureNeverSave": null, //missing translation
     /* Password viewer */
     "savedPasswordsHeading": "Uložená hesla",
     "savedPasswordsEmpty": "Žádná uložená hesla",
+    "savedPasswordsNeverSavedLabel": null, //missing translation
     "deletePassword": "Odstranit heslo pro %s?",
     /* Dialogs */
     "loginPromptTitle": "Přihlášení do %h (%r)", //%h is replaced with host, %r with realm (title of protected part of site)

localization/languages/de.json

@@ -267,9 +267,11 @@
     "passwordCaptureSavePassword": "Zugangsdaten für %s speichern?",
     "passwordCaptureSave": "Speichern",
     "passwordCaptureDontSave": "Nicht speichern",
+    "passwordCaptureNeverSave": null, //missing translation
     /* Password viewer */
     "savedPasswordsHeading": "Gespeicherte Passwörter",
     "savedPasswordsEmpty": "Keine gespeicherte Passwörter",
+    "savedPasswordsNeverSavedLabel": null, //missing translation
     "deletePassword": "Zugangsdaten für %s löschen?",
     /* Dialogs */
     "loginPromptTitle": "Bei %h (%r) anmelden", //%h is replaced with host, %r with realm (title of protected part of site)