Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Pressing Esc to close a select dropdown/menu closes modal dialog #12539

Open
1 task done
patrickhlauke opened this issue Dec 22, 2024 · 2 comments
Open
1 task done
Labels
bug desktop Desktop Application

Comments

@patrickhlauke
Copy link
Contributor

Steps To Reproduce

  1. Open "File > Settings" dialog
  2. Open one of the custom select dropdown/menus (like "Vault timeout")
  3. Press Esc to close the select

Expected Result

The select/dropdown closes, focus returns to the closed dropdown/menu trigger element, but the modal settings dialog remains open.

Actual Result

Both the select dropdown/menu and the settings dialog itself are closed.

Screenshots or Videos

bitwarden-desktop-dropdown-menu-esc.mp4

Video: in Windows, opening the "Vault timeout" select dropdown/menu with the keyboard, then pressing Esc to close it - both the select and the actual settings dialog are closed.

Additional Context

Suspect the solution here is to prevent the Esc keypress from bubbling up and triggering the "close the entire dialog" behaviour.

Similar issue filed for the browser extension: #12525

Operating System

Windows

Operating System Version

11

Installation method

Direct Download (from bitwarden.com)

Build Version

2024.12.1

Issue Tracking Info

  • I understand that work is tracked outside of GitHub. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@patrickhlauke patrickhlauke added bug desktop Desktop Application labels Dec 22, 2024
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-16308

@SergeantConfused
Copy link

Hello @patrickhlauke,

Thank you for your report. I have flagged this to the Engineering department; please feel free to post additional information, such as screenshots or a screen video recordings, if you wish.

Thank you again,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug desktop Desktop Application
Projects
None yet
Development

No branches or pull requests

3 participants