diff --git a/Documentation/Changelog.md b/Documentation/Changelog.md index 7f2fabc..0dac232 100644 --- a/Documentation/Changelog.md +++ b/Documentation/Changelog.md @@ -1,5 +1,17 @@ ## Changelog +### Version 5.2.0 + +This release wraps HockeySDK-Android 5.2.0. + +* **[Improvement]** Replaced obsolete `WWW` request calls with the new `UnityWebRequest` version. + +#### Changelog for HockeySDK-Android 5.2.0 + +* **[Bugfix]** Leaking HTTP connection. +* **[Bugfix]** Fix HTTPS connection creation. +* **[Security]** To enforce TLS 1.2 on all HTTPS connections the SDK makes, we are dropping support for API level 15 (which supports only TLS 1.0), the minimum SDK version thus becomes 16. Previous versions of the SDK were already using TLS 1.2 on API level 16+. + ### Version 5.1.1 This release wraps HockeySDK-Android 5.1.0. diff --git a/ExampleGame/Assets/HockeyAppUnityAndroid/AndroidManifest.xml b/ExampleGame/Assets/HockeyAppUnityAndroid/AndroidManifest.xml index 50d2c93..cd422bd 100644 --- a/ExampleGame/Assets/HockeyAppUnityAndroid/AndroidManifest.xml +++ b/ExampleGame/Assets/HockeyAppUnityAndroid/AndroidManifest.xml @@ -1,11 +1,11 @@ + android:versionCode="20" + android:versionName="5.2.0" > diff --git a/ExampleGame/Assets/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs b/ExampleGame/Assets/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs index cffafea..55dc82f 100644 --- a/ExampleGame/Assets/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs +++ b/ExampleGame/Assets/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs @@ -1,5 +1,5 @@ /* - * Version: 5.1.1 + * Version: 5.2.0 */ using UnityEngine; diff --git a/ExampleGame/Assets/HockeyAppUnityAndroid/HockeySDK-5.1.0.aar b/ExampleGame/Assets/HockeyAppUnityAndroid/HockeySDK-5.1.0.aar deleted file mode 100644 index 352b03e..0000000 Binary files a/ExampleGame/Assets/HockeyAppUnityAndroid/HockeySDK-5.1.0.aar and /dev/null differ diff --git a/ExampleGame/Assets/HockeyAppUnityAndroid/HockeySDK-5.2.0.aar b/ExampleGame/Assets/HockeyAppUnityAndroid/HockeySDK-5.2.0.aar new file mode 100755 index 0000000..d9eb3da Binary files /dev/null and b/ExampleGame/Assets/HockeyAppUnityAndroid/HockeySDK-5.2.0.aar differ diff --git a/ExampleGame/Assets/HockeyAppUnityAndroid/README.pdf b/ExampleGame/Assets/HockeyAppUnityAndroid/README.pdf index 1e642ff..f3e7470 100644 Binary files a/ExampleGame/Assets/HockeyAppUnityAndroid/README.pdf and b/ExampleGame/Assets/HockeyAppUnityAndroid/README.pdf differ diff --git a/Plugins/HockeyAppUnityAndroid/hockeysdk-unity-5.1.0.aar b/ExampleGame/Assets/HockeyAppUnityAndroid/hockeysdk-unity-5.2.0.aar similarity index 94% rename from Plugins/HockeyAppUnityAndroid/hockeysdk-unity-5.1.0.aar rename to ExampleGame/Assets/HockeyAppUnityAndroid/hockeysdk-unity-5.2.0.aar index 9da6ca8..d156173 100644 Binary files a/Plugins/HockeyAppUnityAndroid/hockeysdk-unity-5.1.0.aar and b/ExampleGame/Assets/HockeyAppUnityAndroid/hockeysdk-unity-5.2.0.aar differ diff --git a/HockeyAppUnityPlugin/hockeysdk-unity/build.gradle b/HockeyAppUnityPlugin/hockeysdk-unity/build.gradle index 6bbb515..f20b459 100644 --- a/HockeyAppUnityPlugin/hockeysdk-unity/build.gradle +++ b/HockeyAppUnityPlugin/hockeysdk-unity/build.gradle @@ -4,7 +4,7 @@ android { compileSdkVersion 27 defaultConfig { - minSdkVersion 15 + minSdkVersion 16 targetSdkVersion 27 } @@ -24,5 +24,5 @@ repositories { } dependencies { - compile(name:'HockeySDK-5.1.0', ext:'aar') + compile(name:'HockeySDK-5.2.0', ext:'aar') } diff --git a/HockeyAppUnityPlugin/hockeysdk-unity/libs/HockeySDK-5.1.0.aar b/HockeyAppUnityPlugin/hockeysdk-unity/libs/HockeySDK-5.1.0.aar deleted file mode 100644 index 352b03e..0000000 Binary files a/HockeyAppUnityPlugin/hockeysdk-unity/libs/HockeySDK-5.1.0.aar and /dev/null differ diff --git a/HockeyAppUnityPlugin/hockeysdk-unity/libs/HockeySDK-5.2.0.aar b/HockeyAppUnityPlugin/hockeysdk-unity/libs/HockeySDK-5.2.0.aar new file mode 100755 index 0000000..d9eb3da Binary files /dev/null and b/HockeyAppUnityPlugin/hockeysdk-unity/libs/HockeySDK-5.2.0.aar differ diff --git a/Plugins/HockeyAppUnityAndroid/AndroidManifest.xml b/Plugins/HockeyAppUnityAndroid/AndroidManifest.xml index 50d2c93..cd422bd 100644 --- a/Plugins/HockeyAppUnityAndroid/AndroidManifest.xml +++ b/Plugins/HockeyAppUnityAndroid/AndroidManifest.xml @@ -1,11 +1,11 @@ + android:versionCode="20" + android:versionName="5.2.0" > diff --git a/Plugins/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs b/Plugins/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs index cffafea..61228de 100644 --- a/Plugins/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs +++ b/Plugins/HockeyAppUnityAndroid/HockeyAppUnity-Scripts/HockeyAppAndroid.cs @@ -1,5 +1,5 @@ /* - * Version: 5.1.1 + * Version: 5.2.0 */ using UnityEngine; @@ -8,6 +8,9 @@ using System; using System.IO; using System.Runtime.InteropServices; +#if UNITY_2017_1_OR_NEWER +using UnityEngine.Networking; +#endif public class HockeyAppAndroid : MonoBehaviour { @@ -412,7 +415,12 @@ protected virtual IEnumerator SendLogs (List logs) { var sdkName = pluginClass.CallStatic("getSdkName"); if (sdkName != null) { + #if UNITY_2017_1_OR_NEWER + url += "?sdk=" + UnityWebRequest.EscapeURL(sdkName); + #else url += "?sdk=" + WWW.EscapeURL(sdkName); + #endif + } } #endif @@ -421,12 +429,24 @@ protected virtual IEnumerator SendLogs (List logs) WWWForm postForm = CreateForm (log); string lContent = postForm.headers ["Content-Type"].ToString (); lContent = lContent.Replace ("\"", ""); - Dictionary headers = new Dictionary (); - headers.Add ("Content-Type", lContent); - WWW www = new WWW (url, postForm.data, headers); + + #if UNITY_2017_1_OR_NEWER + UnityWebRequest postRequest = new UnityWebRequest(url, "POST"); + postRequest.SetRequestHeader("Content-Type", lContent); + postRequest.downloadHandler = (DownloadHandler)new DownloadHandlerBuffer(); + postRequest.uploadHandler = (UploadHandler)new UploadHandlerRaw(postForm.data); + + yield return postRequest.SendWebRequest(); + + if (!postRequest.isNetworkError) { + #else + Dictionary headers = new Dictionary(); + headers.Add("Content-Type", lContent); + WWW www = new WWW(url, postForm.data, headers); yield return www; - if (String.IsNullOrEmpty (www.error)) { + if (String.IsNullOrEmpty(www.error)) { + #endif try { File.Delete (log); } catch (Exception e) { @@ -435,7 +455,11 @@ protected virtual IEnumerator SendLogs (List logs) } } else { if (Debug.isDebugBuild) - Debug.Log ("Crash sending error: " + www.error); + #if UNITY_2017_1_OR_NEWER + Debug.Log ("Crash sending error: " + postRequest.error); + #else + Debug.Log("Crash sending error: " + www.error); + #endif } } } diff --git a/Plugins/HockeyAppUnityAndroid/HockeySDK-5.1.0.aar b/Plugins/HockeyAppUnityAndroid/HockeySDK-5.1.0.aar deleted file mode 100644 index 352b03e..0000000 Binary files a/Plugins/HockeyAppUnityAndroid/HockeySDK-5.1.0.aar and /dev/null differ diff --git a/Plugins/HockeyAppUnityAndroid/HockeySDK-5.2.0.aar b/Plugins/HockeyAppUnityAndroid/HockeySDK-5.2.0.aar new file mode 100755 index 0000000..d9eb3da Binary files /dev/null and b/Plugins/HockeyAppUnityAndroid/HockeySDK-5.2.0.aar differ diff --git a/Plugins/HockeyAppUnityAndroid/README.pdf b/Plugins/HockeyAppUnityAndroid/README.pdf index 1e642ff..f3e7470 100644 Binary files a/Plugins/HockeyAppUnityAndroid/README.pdf and b/Plugins/HockeyAppUnityAndroid/README.pdf differ diff --git a/ExampleGame/Assets/HockeyAppUnityAndroid/hockeysdk-unity-5.1.0.aar b/Plugins/HockeyAppUnityAndroid/hockeysdk-unity-5.2.0.aar similarity index 94% rename from ExampleGame/Assets/HockeyAppUnityAndroid/hockeysdk-unity-5.1.0.aar rename to Plugins/HockeyAppUnityAndroid/hockeysdk-unity-5.2.0.aar index 9da6ca8..d156173 100644 Binary files a/ExampleGame/Assets/HockeyAppUnityAndroid/hockeysdk-unity-5.1.0.aar and b/Plugins/HockeyAppUnityAndroid/hockeysdk-unity-5.2.0.aar differ diff --git a/README.md b/README.md index cc8fb73..f6ecc52 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# Version 5.1.1 +# Version 5.2.0 ## Introduction @@ -32,7 +32,7 @@ This document contains the following sections: * [Changelog](Documentation/Changelog.md) * Unity 5.0 or newer (SDK versions with Unity 4 support can be found at the [Unity Asset Store](https://www.assetstore.unity3d.com/en/?gclid=CO) or by switching to the 1.0.3 tag on GitHub). -* Android API level 15 or later. +* Android API level 16 or later. ## Installation & Setup