-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String deriviation paths cause invalid hardening value due to Lodash call #3358
Comments
Thanks for reporting and the PR, @SmartArray. I am looking at this now |
@SmartArray Just so I'm clear, you are not having any issues with the outcome of
If this is "just" a code smell issue (read: not imminently urgent), then we'll want to reconcile #3359 with #3350. The same issue exists, but will inevitably result in merge conflicts between the two. |
We found a flaw with the string typed key derivation function at the following call:
bitcore/packages/bitcore-lib/lib/hdprivatekey.js
Lines 74 to 78 in bed0702
_.every
calls the functionHDPrivateKey.isValidPath
with two args:isValidPath
), which is clearly unintendedAn easy fix is to introduce an anonymous function as shown in this PR: #3359
The text was updated successfully, but these errors were encountered: