-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalAddressBook
: set/update ContactsContract.Settings.*
when address books are renamed and updated
#1113
Comments
The settings are not stored in the account though. I remember you said something about it in call, but please me remind me again, why do we need to save the same settings again? |
I don't mean the davx5-ose/app/src/main/kotlin/at/bitfire/davdroid/resource/LocalAddressBook.kt Lines 450 to 454 in 154d1e6
The More important is the When now an address book is renamed, the rename operation creates a new account, but doesn't set for instance |
Note for myself: Streamline account creation process. Right now EDIT: Reusing the method looks like a bad idea. It simplifies the implementation only a little, but makes it less modular at the same time. The more modular approach is supperior in extensibility and testability does not suffer. |
Currently, settings are only set when address book accounts are created over
create()
.The text was updated successfully, but these errors were encountered: