Bugfix: GUI: Display error messagebox (rather than stderr) when external signer fails inexplicably

luke-jr · luke-jr · commit f4fe307b84b6 · 2023-06-29T22:06:09.000Z
diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp
@@ -466,8 +466,9 @@ bool SendCoinsDialog::signWithExternalSigner(PartiallySignedTransaction& psbtx,
         return false;
     }
     if (err != TransactionError::OK) {
-        tfm::format(std::cerr, "Failed to sign PSBT");
         processSendCoinsReturn(WalletModel::TransactionCreationFailed);
+        const QString msg = tr("Failed to sign PSBT");
+        QMessageBox::critical(nullptr, msg, msg);
         return false;
     }
     // fillPSBT does not always properly finalize

Original file line number	Diff line number	Diff line change
`@@ -466,8 +466,9 @@ bool SendCoinsDialog::signWithExternalSigner(PartiallySignedTransaction& psbtx,`
`466`	`466`	`return false;`
`467`	`467`	`}`
`468`	`468`	`if (err != TransactionError::OK) {`
`469`		`- tfm::format(std::cerr, "Failed to sign PSBT");`
`470`	`469`	`processSendCoinsReturn(WalletModel::TransactionCreationFailed);`
	`470`	`+ const QString msg = tr("Failed to sign PSBT");`
	`471`	`+ QMessageBox::critical(nullptr, msg, msg);`
`471`	`472`	`return false;`
`472`	`473`	`}`
`473`	`474`	`// fillPSBT does not always properly finalize`