From e119c5aff4f4d1cd93bdc20fd02777aad325c824 Mon Sep 17 00:00:00 2001 From: Luke Dashjr Date: Sun, 15 May 2022 21:53:25 +0000 Subject: [PATCH] Bugfix: GUI: Display error messagebox (rather than stderr) when external signer fails inexplicably --- src/qt/sendcoinsdialog.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp index 48f7fb6ad15..d9594f2d361 100644 --- a/src/qt/sendcoinsdialog.cpp +++ b/src/qt/sendcoinsdialog.cpp @@ -466,8 +466,9 @@ bool SendCoinsDialog::signWithExternalSigner(PartiallySignedTransaction& psbtx, return false; } if (err != TransactionError::OK) { - tfm::format(std::cerr, "Failed to sign PSBT"); processSendCoinsReturn(WalletModel::TransactionCreationFailed); + const QString msg = tr("Failed to sign PSBT"); + QMessageBox::critical(nullptr, msg, msg); return false; } // fillPSBT does not always properly finalize