Skip to content

Commit d7fcc91

Browse files
committed
Merge bitcoin/bitcoin#30974: ci: Inline PACKAGE_MANAGER_INSTALL
fafd1a0 ci: Inline PACKAGE_MANAGER_INSTALL (MarcoFalke) Pull request description: The fallback `bash -c "$PACKAGE_MANAGER_INSTALL git"` is only needed by the `lint` task, so simplify it and inline `PACKAGE_MANAGER_INSTALL` once. Also, fixup the docs to add some other packages which are needed by podman in user-mode. ACKs for top commit: fanquake: ACK fafd1a0 Tree-SHA512: e1665446d0fb5a2e8f2cb912117c7a42838c840199e7504a859b9155a13a2ff2e8606ac56689446f973fce02b00240041f071ebf00520778ed81eb1a01de6663
2 parents 29d00a1 + fafd1a0 commit d7fcc91

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

.cirrus.yml

+6-8
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
env: # Global defaults
22
CIRRUS_CLONE_DEPTH: 1
33
CIRRUS_LOG_TIMESTAMP: true
4-
PACKAGE_MANAGER_INSTALL: "apt-get update && apt-get install -y"
54
MAKEJOBS: "-j10"
65
TEST_RUNNER_PORT_MIN: "14000" # Must be larger than 12321, which is used for the http cache. See https://cirrus-ci.org/guide/writing-tasks/#http-cache
76
CI_FAILFAST_TEST_LEAVE_DANGLING: "1" # Cirrus CI does not care about dangling processes and setting this variable avoids killing the CI script itself on error
@@ -14,9 +13,9 @@ env: # Global defaults
1413
# Generally, a persistent worker must run Ubuntu 23.04+ or Debian 12+.
1514
#
1615
# The following specific types should exist, with the following requirements:
17-
# - small: For an x86_64 machine, recommended to have 2 CPUs and 8 GB of memory.
18-
# - medium: For an x86_64 machine, recommended to have 4 CPUs and 16 GB of memory.
19-
# - arm64: For an aarch64 machine, recommended to have 2 CPUs and 8 GB of memory.
16+
# - small: For an x86_64 machine, with at least 2 vCPUs and 8 GB of memory.
17+
# - medium: For an x86_64 machine, with at least 4 vCPUs and 16 GB of memory.
18+
# - arm64: For an aarch64 machine, with at least 2 vCPUs and 8 GB of memory.
2019
#
2120
# CI jobs for the latter configuration can be run on x86_64 hardware
2221
# by installing qemu-user-static, which works out of the box with
@@ -37,14 +36,13 @@ env: # Global defaults
3736
# This requires installing Podman instead of Docker.
3837
#
3938
# Futhermore:
40-
# - apt-get is required due to PACKAGE_MANAGER_INSTALL
4139
# - podman-docker-4.1+ is required due to the bugfix in 4.1
4240
# (https://github.com/bitcoin/bitcoin/pull/21652#issuecomment-1657098200)
4341
# - The ./ci/ dependencies (with cirrus-cli) should be installed. One-liner example
4442
# for a single user setup with sudo permission:
4543
#
4644
# ```
47-
# apt update && apt install git screen python3 bash podman-docker curl -y && curl -L -o cirrus "https://github.com/cirruslabs/cirrus-cli/releases/latest/download/cirrus-linux-$(dpkg --print-architecture)" && mv cirrus /usr/local/bin/cirrus && chmod +x /usr/local/bin/cirrus
45+
# apt update && apt install git screen python3 bash podman-docker uidmap slirp4netns curl -y && curl -L -o cirrus "https://github.com/cirruslabs/cirrus-cli/releases/latest/download/cirrus-linux-$(dpkg --print-architecture)" && mv cirrus /usr/local/bin/cirrus && chmod +x /usr/local/bin/cirrus
4846
# ```
4947
#
5048
# - There are no strict requirements on the hardware. Having fewer CPU threads
@@ -73,8 +71,8 @@ filter_template: &FILTER_TEMPLATE
7371
base_template: &BASE_TEMPLATE
7472
<< : *FILTER_TEMPLATE
7573
merge_base_script:
76-
# Unconditionally install git (used in fingerprint_script).
77-
- git --version || bash -c "$PACKAGE_MANAGER_INSTALL git"
74+
# Require git (used in fingerprint_script).
75+
- git --version || ( apt-get update && apt-get install -y git )
7876
- if [ "$CIRRUS_PR" = "" ]; then exit 0; fi
7977
- git fetch --depth=1 $CIRRUS_REPO_CLONE_URL "pull/${CIRRUS_PR}/merge"
8078
- git checkout FETCH_HEAD # Use merged changes to detect silent merge conflicts

0 commit comments

Comments
 (0)