Refactor: Replace 'isMockableChain' with inline 'ChainType' check for 'submitpackage'

devtimnbr · devtimnbr · commit 78c2707b2aef · 2023-09-15T16:32:11.000+02:00
diff --git a/src/rpc/mempool.cpp b/src/rpc/mempool.cpp
@@ -862,7 +862,7 @@ static RPCHelpMan submitpackage()
         },
         [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue
         {
-            if (!Params().IsMockableChain()) {
+            if (Params().GetChainType() != ChainType::REGTEST) {
                 throw std::runtime_error("submitpackage is for regression testing (-regtest mode) only");
             }
             const UniValue raw_transactions = request.params[0].get_array();

Original file line number	Diff line number	Diff line change
`@@ -862,7 +862,7 @@ static RPCHelpMan submitpackage()`
`862`	`862`	`},`
`863`	`863`	`[&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue`
`864`	`864`	`{`
`865`		`- if (!Params().IsMockableChain()) {`
	`865`	`+ if (Params().GetChainType() != ChainType::REGTEST) {`
`866`	`866`	`throw std::runtime_error("submitpackage is for regression testing (-regtest mode) only");`
`867`	`867`	`}`
`868`	`868`	`const UniValue raw_transactions = request.params[0].get_array();`