doc: update BroadcastTransaction comment

ismaelsadeeq · ismaelsadeeq · commit 31cce4a1bdbb · 2024-01-29T13:07:47.000+01:00
BroadcastTransaction is also called by submitpackage RPC.

It's not maintainable to list all the callers of a function.
diff --git a/src/node/transaction.cpp b/src/node/transaction.cpp
@@ -32,7 +32,7 @@ static TransactionError HandleATMPError(const TxValidationState& state, std::str
 
 TransactionError BroadcastTransaction(NodeContext& node, const CTransactionRef tx, std::string& err_string, const CAmount& max_tx_fee, bool relay, bool wait_callback)
 {
-    // BroadcastTransaction can be called by either sendrawtransaction RPC or the wallet.
+    // BroadcastTransaction can be called by RPC or by the wallet.
     // chainman, mempool and peerman are initialized before the RPC server and wallet are started
     // and reset after the RPC sever and wallet are stopped.
     assert(node.chainman);

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ static TransactionError HandleATMPError(const TxValidationState& state, std::str`
`32`	`32`
`33`	`33`	`TransactionError BroadcastTransaction(NodeContext& node, const CTransactionRef tx, std::string& err_string, const CAmount& max_tx_fee, bool relay, bool wait_callback)`
`34`	`34`	`{`
`35`		`- // BroadcastTransaction can be called by either sendrawtransaction RPC or the wallet.`
	`35`	`+ // BroadcastTransaction can be called by RPC or by the wallet.`
`36`	`36`	`// chainman, mempool and peerman are initialized before the RPC server and wallet are started`
`37`	`37`	`// and reset after the RPC sever and wallet are stopped.`
`38`	`38`	`assert(node.chainman);`