From 1308b837dc3499896ca73eafa51ac69b455cef00 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Tue, 17 Jan 2023 12:56:18 +0000 Subject: [PATCH] clang-tidy: Fix `performance-no-automatic-move` in headers See https://clang.llvm.org/extra/clang-tidy/checks/performance/no-automatic-move.html --- src/script/miniscript.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/script/miniscript.h b/src/script/miniscript.h index fa3b0350e98..3a3f724f031 100644 --- a/src/script/miniscript.h +++ b/src/script/miniscript.h @@ -1378,7 +1378,7 @@ inline NodeRef Parse(Span in, const Ctx& ctx) assert(constructed.size() == 1); assert(constructed[0]->ScriptSize() == script_size); if (in.size() > 0) return {}; - const NodeRef tl_node = std::move(constructed.front()); + NodeRef tl_node = std::move(constructed.front()); tl_node->DuplicateKeyCheck(ctx); return tl_node; } @@ -1813,7 +1813,7 @@ inline NodeRef DecodeScript(I& in, I last, const Ctx& ctx) } } if (constructed.size() != 1) return {}; - const NodeRef tl_node = std::move(constructed.front()); + NodeRef tl_node = std::move(constructed.front()); tl_node->DuplicateKeyCheck(ctx); // Note that due to how ComputeType works (only assign the type to the node if the // subs' types are valid) this would fail if any node of tree is badly typed.