From fb46d57d4e7263495c007f4a499a349bff2b21e0 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Thu, 24 Oct 2024 11:27:16 +0100 Subject: [PATCH] cmake, qt, test: Remove problematic code The removed code aimed to make Qt's minimal integration plugin DLL available for `test_bitcoin-qt.exe` on Windows. However, there are two issues: 1. The code is broken because the destination directory must end with a trailing slash (`/`). 2. It is unnecessary because Qt's minimal integration plugin is not used on Windows. For more details, please refer to the following code. --- src/qt/test/CMakeLists.txt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/qt/test/CMakeLists.txt b/src/qt/test/CMakeLists.txt index 582ed714663..8ce571c1501 100644 --- a/src/qt/test/CMakeLists.txt +++ b/src/qt/test/CMakeLists.txt @@ -32,14 +32,6 @@ if(ENABLE_WALLET) ) endif() -if(NOT QT_IS_STATIC) - add_custom_command( - TARGET test_bitcoin-qt POST_BUILD - COMMAND ${CMAKE_COMMAND} -E copy_if_different $>> $/plugins/platforms - VERBATIM - ) -endif() - add_test(NAME test_bitcoin-qt COMMAND test_bitcoin-qt )