Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable .editorconfig support by default #4812

Open
Tracked by #3727
ematipico opened this issue Dec 30, 2024 · 3 comments
Open
Tracked by #3727

Enable .editorconfig support by default #4812

ematipico opened this issue Dec 30, 2024 · 3 comments
Assignees

Comments

@ematipico
Copy link
Member

No description provided.

@fireairforce
Copy link
Member

Is there any more detailed information to add to this issue? Can I directly refer to prettier here?

@ematipico
Copy link
Member Author

.editorconfig is already supported, but at the moment it's an opt-in feature.

The task is to default the value to true, update the tests, and make sure that the existing functionalities work as expected.

@fireairforce fireairforce self-assigned this Jan 21, 2025
@arendjr
Copy link
Contributor

arendjr commented Jan 21, 2025

Note we had a bit of discussion around this on Discord: https://discord.com/channels/1132231889290285117/1132614451565170819/1326570605683671141

I think the gist of it is that we should be careful when both a biome.json and an .editorconfig are present. If both exist, formatter settings from the biome.json take precedence. If a biome.json exists without formatter settings , and an .editorconfig file exists in a directory higher up in the hierarchy, then default formatter settings should be used and the .editorconfig file should be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants