📎 Implement useImmediateReturn

[dyc3]

Description

Port the prefer-immediate-return rule from eslint-plugin-sonarjs.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

[ematipico]

This sounds like more an assist action rather than a lint rule 🤔

[florianmatz]

@ematipico eslint itself has kind of the same rule - arrow-body-style when configured to ‘as-needed’ or ‘never’.

[ematipico]

Yeah but this is a styling thing and it doesn't fit our rule pillars. An assist action seems to cover that

[florianmatz]

🤷 - this can be said for a bunch of rules like ‘ useConsistentCurlyBraces’? Also more style related IMHO and still useful / relevant?

[ematipico]

Yes, there's a good chance we're going to move it

[dyc3]

After looking at it again, I agree that this seems like an assist. Do we have guidelines (like our rule pillars) for what should be a lint vs assist?

[ematipico]

@dyc3

I usually use our rule pillars to understand if a rule should be part of the linter or not.

Another thing that I use as a guideline is editors. IntelliJ comes to mind, for example. For useImmediateReturn, this is usually suggested as a refactor opportunity by the editor.