Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Biome Linting Runs in Projects Without Configuration or Dependency When VSCode Extension is Enabled #330

Open
1 of 3 tasks
poteboy opened this issue Sep 6, 2024 · 6 comments

Comments

@poteboy
Copy link

poteboy commented Sep 6, 2024

VS Code version

1.92.2

Extension version

2.3.0

Biome version

1.8.3

Operating system

  • Windows
  • macOS
  • Linux

Description

The Biome linter runs on projects where it is not configured or installed. Specifically, Biome executes linting even when:

  • The project’s package.json does not include a Biome dependency.
  • There is no biome.json or any other configuration file related to Biome in the project.
  • Biome VSCode Extension is enabled, and Biome Binary may be globally installed.
スクリーンショット 2024-09-06 12 02 50

Steps to reproduce

  1. Open a project in VSCode where Biome is not listed as a dependency in package.json.
  2. Ensure that there is no biome.json or similar configuration in the project.
  3. Confirm that the Biome is enabled (Biome 1.8.3 (bundled) as shown in the screenshot).
  4. Notice that Biome still runs linting on files (e.g., showing errors such as "This else clause can be omitted...").
スクリーンショット 2024-09-06 12 14 26

Expected behavior

Biome should not run linting in projects unless explicitly installed or configured within the project settings or dependency files.

Does this issue occur when using the CLI directly?

Not sure / Not applicable

Link to a minimal reproduction

No response

Logs

No response

@poteboy poteboy added the Triage label Sep 6, 2024
@ArthurLobopro
Copy link

I have the same problem, sometimes I open a project that uses ESLint or other linter but Biome keeps showing errors and as there is no biome configuration it shows all recomended errors

@RexSkz
Copy link

RexSkz commented Sep 14, 2024

Switching to the pre-release version solves this issue for me. (Please refer to biomejs/biome#1630)

Hope the support of multi-folder workspaces to be released soon!

@unvalley
Copy link
Member

unvalley commented Sep 17, 2024

I think this will be resolved by the pre-release of v3, could you try that?

Set true to the biome.requireConfigFile: https://deploy-preview-974--biomejs.netlify.app/reference/vscode/#biomerequireconfigfile

@kotasudhakar
Copy link

There is still an issue i am facing when there is an biome extension installed but no biome json file is there in the repo, still the biome is showing those as errors. I dont want it as in this repo i have already prettier and eslint configured. I am using biome extension version 1.9.2

@ematipico
Copy link
Member

@kotasudhakar did you follow the conversation? Did you try the pre-release with the new extension configuration?

If so, then please create a reproduction and open a new issue

@tschaub
Copy link

tschaub commented Oct 3, 2024

I was looking for a solution to this same issue and tried the latest pre-release (v2024.10.204580). When I add "biome.requireConfigFile": true to my user settings.json file, I get the following dialog when I open a JS file:

image

See #375 for details.

@nhedger nhedger added the Stable label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants