-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnifiedPush: Respond with 404/409/... to Mastodon/etc. instead of 507 based on User-Agent #664
Comments
Returning 404 for all non existant UnifiedPush requests (where up=1) will follow UnifiedPush spec and Webpush spec and probably avoid many issues :)
|
From the discussion in chat: |
@karmanyaahm @p1gp1g I am inclined to close this, since nobody has complained. The 5xx rates are still high, but I have just learned to live with it ... Thoughts? |
If no one's having noticable problems, it ought to be fine. Still kinda weird it hasn't normalized down though :/ |
EDITED by @binwiederhier: Removed image containing lots of 507 errors to UP topics. The UP topics are secrets, so I removed the picture. It keeps happening and increasing. |
@Lastorder-DC please censor the picture. Unified Push topics are secrets. Edit: I took the liberty of removing the image for you. |
This is happening because your server is pushing messages to topics that do not have any subscribers. They are dead topics. The alternative to returning 507 would be to let them through, but then you'd get rate limited and banned within a matter of minutes. So you can either live with the errors, or manually purge the topics from Mastodon. I am also ok with pull requests to handle it specifically for Mastodon if there are suggestions. |
@binwiederhier Forgot that. Sorry! (Actually I have sensored them but accidently choose non-sensored version...) |
We're seeing a buildup of push messages to ntfy.sh, presumably to UP. Returning a 4XX code so that the queue is deleted would help a lot, since we're continually getting IP banned by the sheer volume of requests backed up. Also relevant: mastodon/mastodon#26078 |
I've talked with @karmanyaahm about this issue, and the consensus seems to be that, 12h after deletion, nfty should be returning 410s for a given subscription. |
Actually, the |
Similar to the Matrix Push Gateway change, we should respond to Mastodon/etc. in a way that will make them delete the push subscription.
Mastodon:
https://github.com/mastodon/mastodon/blob/730bb3e211a84a2f30e3e2bbeae3f77149824a68/app/workers/web/push_notification_worker.rb#L35-L46
Common-Proxies:
https://github.com/UnifiedPush/common-proxies/blob/main/gateway/matrix.go#L63
/cc FYI @karmanyaahm @p1gp1g
The text was updated successfully, but these errors were encountered: