Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage / -- loads then crashes entire page, when GitHub API call returns 403 #1217

Open
mcint opened this issue Nov 5, 2024 · 0 comments
Labels
🪲 bug Something isn't working

Comments

@mcint
Copy link

mcint commented Nov 5, 2024

🐞 Describe the bug
For the https://ntfy.sh homepage, and not on the Notifications / Subscriptions / Message-sending page, for unknown reasons I temporarily exceeded limits api.github.com.

While ntfy.sh requested https://api.github.com/repos/binwiederhier/ntfy, I presume for the live Stars count, the homepage would flash as loaded, then report a total crash. The api requests were receiving 403 reponses, {"message":"API rate limit exceeded for [ip]. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}.

I would be nice the the homepage gracefully degraded and was still usable, when dependencies are returning non-success statuses.

💻 Components impacted
Web homepage, ntfy.sh. Not the web app.

💡 Screenshots and/or logs

🔮 Additional context

@mcint mcint added the 🪲 bug Something isn't working label Nov 5, 2024
@mcint mcint changed the title Homepage index -- loads then crashes entire page, when GitHub API call returns 403 Homepage / -- loads then crashes entire page, when GitHub API call returns 403 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant