Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whiteout detection should be more robust #42

Open
mgree opened this issue Jun 24, 2023 · 1 comment
Open

Whiteout detection should be more robust #42

mgree opened this issue Jun 24, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers testing Tests need to be added or revised

Comments

@mgree
Copy link
Contributor

mgree commented Jun 24, 2023

Right now we detect whiteout files with [ -c "$changed_file" ] && ! [ -s "$changed_file" ]... but we should also check that the major/minor numbers are 0/0 in case someone has some non-whiteout, empty character device file. (Hard to imagine this happening, but safety first.)

@mgree mgree added bug Something isn't working good first issue Good for newcomers labels Jun 24, 2023
@angelhof angelhof self-assigned this Jun 26, 2023
@angelhof
Copy link
Member

This is resolved by #71. However, ideally we also want to add a test that checks that non-whiteout character device files created in try are not mistakenly assumed to be whiteout files. This is not that easy to do since it either requires sudo access (and mknod still fails in try due to permissions), or a fuse character device file.

Let's keep this issue open until such a test is implemented. Some discussion on attempts to implement this test can be found in #71.

@mgree mgree added testing Tests need to be added or revised and removed bug Something isn't working labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing Tests need to be added or revised
Projects
None yet
Development

No branches or pull requests

2 participants