Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with less noise #28

Open
arielshaqed opened this issue Aug 1, 2019 · 0 comments
Open

Allow building with less noise #28

arielshaqed opened this issue Aug 1, 2019 · 0 comments

Comments

@arielshaqed
Copy link

What

Building e.g. a client package outputs these lines to standard error:

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN @binaris/[email protected] No license field.

This causes pain e.g. when using Rush.

Give some way to prevent these 2 outputs.

Suggestions:

  1. Copy license from package.json of generating package to generated package.json. This doesn't have to be (probably shouldn't be) the license field, it could be instead generated-license. That fixes the "warning" -- which is really always a bug. (Maybe also allow setting private there?)
  2. Add an option --npm-install-args so I can pass --npm-install-args=--no-package-lock and get rid of the "notice".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant