chore: Remove schema experiment from legacy validator #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1932 +/- ##
==========================================
+ Coverage 83.57% 88.05% +4.47%
==========================================
Files 92 39 -53
Lines 3890 2193 -1697
Branches 1271 272 -999
==========================================
- Hits 3251 1931 -1320
+ Misses 541 256 -285
+ Partials 98 6 -92 ☔ View full report in Codecov by Sentry. |
effigies
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the confusing --schema option from the legacy validator. This was an experiment to begin integrating the schema for validation around BIDS 1.6.0 and 1.7.0 but it is incomplete and the Deno validator is the preferred way to validate based on the BIDS schema.
See #1930.