Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clojure.data.json dep missing #329

Open
lgrapenthin opened this issue May 15, 2022 · 8 comments
Open

clojure.data.json dep missing #329

lgrapenthin opened this issue May 15, 2022 · 8 comments

Comments

@lgrapenthin
Copy link

ClojureScript 1.11.51 doesn't pull that one in anymore...

@bhauman
Copy link
Owner

bhauman commented May 15, 2022

Good one! I'll fix that.

@bhauman
Copy link
Owner

bhauman commented May 16, 2022

Hmmm did you add the dep in your local project, and did everything work. Because I'm now getting a missing cljs/vendor/bridge.clj file now. Are you getting that?

@lgrapenthin
Copy link
Author

lgrapenthin commented May 16, 2022 via email

@bhauman
Copy link
Owner

bhauman commented May 16, 2022

Wait, my question was sprawling, so you are missing the cljs/vendor/bridge.clj file now?

@svenlaater
Copy link

svenlaater commented May 16, 2022

Wait, my question was sprawling, so you are missing the cljs/vendor/bridge.clj file now?

yes

Maybe related to this https://github.com/clojure/clojurescript/compare/cljs-3375?

Also, production builds pass when org.clojure/data.json is added to deps but starting REPL does not.

Results: Stored in vars *1, *2, *3, *e holds last exception object
[Rebel readline] Type :repl/help for online help info
Execution error (FileNotFoundException) at cljs.repl/repl* (repl.cljc:1060).
Could not locate vendor/bridge__init.class, vendor/bridge.clj or vendor/bridge.cljc on classpath.

com.bhauman/figwheel-main {:mvn/version "0.2.17"}

@bhauman
Copy link
Owner

bhauman commented May 16, 2022

cool thanks!

@bhauman
Copy link
Owner

bhauman commented May 16, 2022

So for now the simple solution right now is to add clojure.data.json, as a dependency and use a ClojureScript 1.11.54 when it is released momentarily.

I will also release figwheel-main 0.2.18 which will include the clojure.data.json dep in it.

@johanatan
Copy link

Is this going to be fixed anytime soon? Pretty bad look for a project to require users to just randomly add dependencies its upstream dependencies require.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants