Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile in :advanced mode #8

Open
thheller opened this issue May 27, 2020 · 0 comments
Open

Can't compile in :advanced mode #8

thheller opened this issue May 27, 2020 · 0 comments

Comments

@thheller
Copy link

There is a dynamic set! for a goog-define which makes the Closure compiler error out when compiling cljs-test-display in :advanced mode.

It errors out with

--- cljs_test_display/core.cljs:411
illegal initialization of @define variable cljs_test_display.core.root_node_id

which is this line

(set! root-node-id (name app-node-id)))

According to the Closure rules the @define vars (via goog-define) must be treated as constants and cannot be updated dynamically. Not sure this check has always been there but it currently prevents using cljs-test-display in :advanced builds. Works fine in :none but something it'd nice to run the tests against :advanced compiled code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant