Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for successful builds persist unnecessarily #3

Open
empperi opened this issue Jan 24, 2019 · 3 comments
Open

Notifications for successful builds persist unnecessarily #3

empperi opened this issue Jan 24, 2019 · 3 comments

Comments

@empperi
Copy link

empperi commented Jan 24, 2019

Currently when cljs-test-display runs a successful test run it gives you a notification that the build has succeeded. This is a nice feature but unfortunately these do persist afterwards and keep on piling up. It is not rare to see over 50 notifications waiting when doing ClojureScript programming with cljs-test-display on.

This is fortunately easily remedied: by using the Notifications API .close() method one can close these success build notifications after some time (5 seconds maybe?). Please see https://developer.mozilla.org/en-US/docs/Web/API/Notification/close for reference.

@dpsutton
Copy link

Just a data point: this does not happen on Fedora 29 with gnome on wayland. Interesting this hasn't popped up for anyone else.

@empperi
Copy link
Author

empperi commented Jan 25, 2019

Maybe I'm the only one using Windows? :) Native notifications in Windows do persist if you do not remove those either programmatically or manually. It actually makes sense that they do and I'm a little shocked that other operating systems would lose that information: you might miss something important. If programmer explicitly removes the notification then it is kinda obvious that no harm is done if it is missed.

@tomvdsom
Copy link

tomvdsom commented Feb 8, 2019

Verified that notifications also persist on Mac OSX Mojave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants