Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check AI interfaces for UnitDestroyed change #1718

Open
sprunk opened this issue Oct 6, 2024 · 0 comments
Open

Check AI interfaces for UnitDestroyed change #1718

sprunk opened this issue Oct 6, 2024 · 0 comments
Labels
refactor Internal code cleanup; paying off technical debt; janitorial work.

Comments

@sprunk
Copy link
Collaborator

sprunk commented Oct 6, 2024

See my unaddressed comment at #1669 (comment)

  • if existing AIs (Circuit/Barbarian, etc) use the event, then won't they fail to build due to different function signature?
  • if they build correctly then was the correct function even modified?
@sprunk sprunk added the refactor Internal code cleanup; paying off technical debt; janitorial work. label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Internal code cleanup; paying off technical debt; janitorial work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sprunk