Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input signal autodetect #24

Open
DieHertz opened this issue Jan 16, 2018 · 9 comments
Open

Add input signal autodetect #24

DieHertz opened this issue Jan 16, 2018 · 9 comments
Assignees

Comments

@DieHertz
Copy link
Member

Currently the code seems broken, there is a DSHOT implementation taken from desolateESC, but I think it's not used anywhere.
I'm going to add various PWM protocols and DSHOT support.

@DieHertz DieHertz self-assigned this Jan 16, 2018
@brycedjohnson
Copy link
Contributor

Dshot is supposed to be self clocking right? Did we need to have dshot 150/300/600/1200 or could it figure it out on its own. Isn't the kiss pretty flexible on dshot - like you could put dshot 450 into it and it would handle it just fine?

@DieHertz
Copy link
Member Author

I'm talking about autodetect for pwm and DSHOT as a whole, blheli also didn't constrain dshot rate and is flexible as kiss.

This enum with different DSHOT rates I'll remove.

@brycedjohnson
Copy link
Contributor

At least in blheli_s: https://github.com/bitdump/BLHeli/blob/master/BLHeli_S%20SiLabs/BLHeli_S.asm#L3637

There is a check for 150, 300, 600

Maybe blheli_32 does something different?

@DieHertz
Copy link
Member Author

Indeed, but we're better than BLHS, right? :-) As about BLH32, no idea

@nitr0123
Copy link

nitr0123 commented Jan 19, 2018

Sorry if this is the wrong place to ask. I'd love to help but don't know where to start. Is there some code I can read or a book etc to get started and possibly contribute ?
Should I be reading blheli ? asm is a bit hard to understand.
Edit: Would it be useful / possible to have a look at field oriented control ?

@DieHertz
Copy link
Member Author

@nitr0123 This particular issue I'm already working on, in general looking at BLHeli_S code might give some insight, as well as current project C code.

@stale
Copy link

stale bot commented May 23, 2018

This issue / pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@stale stale bot added the Inactive label May 23, 2018
@stale stale bot removed the Inactive label May 23, 2018
@jaxxzer
Copy link
Contributor

jaxxzer commented May 28, 2018

Any progress on this @DieHertz?

@jaxxzer
Copy link
Contributor

jaxxzer commented Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants