S3 Multi Upload

[variousred]

sort of related to #38
where i've made a couple comments

[variousred]

@digitaltoad i'm still getting this issue with 0.3.9 ... not sure why. I'm using the S3Uploader

@digitaltoad if (Ember.isArray(files)) { never returns true. The upload method is only passed a single file at a time with uploader.upload(files[0]); // Uploader will send a sign request then upload to S3

[digitaltoad]

Multi uploads have always been a sore spot with this library. I don’t think I’ve ever fully supported multi file uploads with S3. I can look into though.

—
Josh

On Wed, Aug 26, 2015 at 9:54 PM, Michael Mitchell
[email protected] wrote:

@digitaltoad i'm still getting this issue with 0.3.9 ... not sure why. I'm using the S3Uploader
@variousred

variousred commented 21 minutes ago

@digitaltoad if (Ember.isArray(files)) { never returns true. The upload method is only passed a single file at a time with uploader.upload(files[0]); // Uploader will send a sign request then upload to S3

Reply to this email directly or view it on GitHub:
#85 (comment)

[variousred]

Dont know why I didnt think of this yesterday, but a fix was easy enough:

    if(!Ember.isEmpty(files))
      $(".asset-total").text(files.length)
      loader.show()
      label.hide()
      for file in files
        uploader.upload(file)

just call the uploader once for each file iteratively

[digitaltoad]

That was my initial fix.

—
Josh

On Thu, Aug 27, 2015 at 7:09 PM, Michael Mitchell
[email protected] wrote:

Dont know why I didnt think of this yesterday, but a fix was easy enough:

    if(!Ember.isEmpty(files))
      $(".asset-total").text(files.length)
      loader.show()
      label.hide()
      for file in files
        uploader.upload(file)

just call the uploader once for each file iteratively

Reply to this email directly or view it on GitHub:
#85 (comment)

[variousred]

Though it works well enough, doesn't feel quite right since uploader#upload is designed to handle an array of files

[digitaltoad]

I would like to handle it a bit different. The problem arises over progress and the expectation around per file or per request events. It could be configurable.

—
Josh

On Thu, Aug 27, 2015 at 7:40 PM, Michael Mitchell
[email protected] wrote:

Though it works well enough, doesn't feel quite right since uploader#upload is designed to handle an array of files

Reply to this email directly or view it on GitHub:
#85 (comment)