No dashboard using starter

[chadams]

I’m not able to access the dashboard after creating from starter.

npm create pocketpages 
# choose “data star”
pocketbase serve —dir=pb_data —dev

navigate to ‘/_/‘ and you get the root page instead?

[VictorioBerra]

THis is a bug.

I launched a codespace here, ran bun dev cd ./packages/starters/datastar ran pocketbase --dev serve and I am unable to access the pocketbase dashboard.

Still investigating.

[VictorioBerra]

I think this is a regression from #83

@rodrigorm can you investigate? I added this test to your code:

test('returns null for underscore prefix route', () => {
  const routes = [
    baseRoute({ segments: [{ nodeName: 'index' }], relativePath: 'index' }),
    baseRoute({ segments: [{ nodeName: 'about' }], relativePath: 'about' }),
    baseRoute({
      segments: [{ nodeName: '', paramName: 'id' }],
      relativePath: '[id]',
    }),
  ]
  const url = { pathname: '/_', query: {} }
  const result = resolveRoute(url as any, routes as any)
  expect(result).toBeNull()
})

result is:

{
  route: {
    segments: [
      [Object ...]
    ],
    isStatic: true,
    fingerprint: "abc",
    relativePath: "[id]",
  },
  params: {
    id: "_",
  },
}

I assume this prevents dashboard access? Im thinking the datastar starter uses (site)/[roomName] which catches /_

[benallfree]

Ooo snap yes this is correct. [roomName] will catch everything.

I wonder if we could solve this most easily by modifying the starter to have _.ejs

<script server>
// _.ejs
return next()
</script>

or somethign like that? I'd rather not whitelist paths in case a user does want to hide the PB admin for some reason.

[rodrigorm]

@VictorioBerra can you provide the logs from the pocketbase running instance? Enable debug mode if necessary please.

[benallfree]

Yeah guys this is such a corner case I don't think we really need to address it in the core. I changed the datastar starter kit as follows:

<script server>
  // Allow admin requests through
  if (request.url.pathname.startsWith('/_')) {
    return request.event.next()
  }

  const { roomName } = params
  const messages = store(`room_${roomName}`) || []
</script>

<%- include('chat.ejs', { roomName, messages }) %> 

[benallfree]

Fixed in 5bc48d4

@chadams Please delete and re-install the starter, it should pick up this change.