Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support packages with extension modules #10

Open
hroncok opened this issue Nov 24, 2021 · 3 comments
Open

Support packages with extension modules #10

hroncok opened this issue Nov 24, 2021 · 3 comments

Comments

@hroncok
Copy link
Contributor

hroncok commented Nov 24, 2021

The tool currently only supports noarch pacakges, the noarch thing is hardcoded in the template. It would be nice if it also supported packages with extension modules - those are archful and usually need at least gcc to build.

@befeleme
Copy link
Owner

Taking a look at Packaging Guidelines and some arched spec files this is needed in template.spec:

  • if package is not arched, print the line BuildArch: noarch (that'd be the default)
  • otherwise (set by a flag) the line wouldn't be printed to the spec file

Also, it could be possible to define ExcludeArch: and ExclusiveArch: in the config.
It's already possible to define custom BuildRequires: in addition to the generated ones.

Will it be enough to make it working?

@hroncok
Copy link
Contributor Author

hroncok commented Nov 24, 2021

I suppose the conf2spec tool needs a way to say we don't want noarch (I would not bother with ExcludeArch: and ExclusiveArch:) and a way to say we need gcc (the option already exists).

For automated rebuilds to work, the pyp2conf tool would need to detect this and add the proper config options.

@befeleme
Copy link
Owner

Detecting the existence of extension modules naively by parsing all available wheel names: #40
A draft of PEP that would make it possible to detect that in an explicit way: https://peps.python.org/pep-0725/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants