-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acoustid submission error: response is not valid JSON - 504 gateway time-out #62
Comments
Hmm; that's odd. Any chance you could view the API request and response to see if there's an underlying error? Observing the traffic with Wireshark or similar would work, as would just |
Oh maybe. Thanks @BNolet I just install wireshark, I forgot I could use that. The library returned error wasn't very helpful then, maybe it should've said: Service unavailable. It seems beet (and picard) uses only album/artist to find matches indeed. II can't find a status page for the apis, we'll have to wait. |
Yeah! A PR here would be welcome if anyone has a moment to add a better error message for 5xx error codes. |
Welp, Picard is working just fine so I'm going to use that to tag my library :) https://picard.musicbrainz.org/ |
@BNolet On my end I can tag using beet, I just can't use fingerprints or upload them - same as Picard ATM. Using picard if I try to upload a fingerprint I see the request in the logs with no error but it never shows on the website and it usually shows the fingerprint on the website pretty fast. |
@Extarys Ah maybe Picard is just working for matching recordings and not submissions then, sorry to hear that |
I think this need further investigation. This is Picard log:
Fingerprint was uploaded: https://musicbrainz.org/recording/65161f21-ae51-48f4-84c0-2f7f53662081/fingerprints I think yesterday I didn't properly submit in Picard, that is why I thought it wasn't wokring. If it works in Picard but not in Beet, I think it can impact the number of fingerprints that will end up on the Brainz server. 😞 |
I also get the same error here (504), but querying the api with the same parameters through browser/wget/curl works fine. |
Correction: if I send the request as plain text through curl it works, if I send it gzipped as I think pyacoustid does I get a 504. But I could easily have gotten something wrong in these tests. |
Further info: if I disable gzipping in acoustid.py everything seems to work correctly. My picard sends the request as plain text (urlencoded) and works. |
@skapazzo Can you explain how to disable gzip in acoustid? I just use it straight in beet though and the beet plugin config doesn't show much options. Do I need to change this directly in the python file? |
Yes, I just hacked acoustid.py. I forked pyacoustid and uploaded the changes I used for testing. You can see the diff here: master...skapazzo:skapazzo-temporary |
Oh wow, thanks for tracking that down! Seems like something is wrong on the server side with gzipped requests. Paging @lalinsky in case he hasn't seen this thread yet. It also looks like there is a related server issue filed at acoustid/acoustid-server#50. |
Thanks guys. The service has been heavily overloaded during the last weeks, so I had to work on some frontend proxying and it's possible that some gzipped request support got broken. I'll have a look quickly. |
I'm adding new releases in MB database and I was curious after tagging why the fingerprint wasn't on the website and I received no errors so I explicitly tried with the
submit
comment.Output:
I tried multiple tracks, I always get that error - I also confirmed my API key.
Config:
Any tips?
The text was updated successfully, but these errors were encountered: