Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lyrics: Use MusicBrainz artist aliases if default query is not found #3340

Closed
octos opened this issue Aug 3, 2019 · 3 comments · Fixed by #3558
Closed

lyrics: Use MusicBrainz artist aliases if default query is not found #3340

octos opened this issue Aug 3, 2019 · 3 comments · Fixed by #3558
Labels
feature features we would like to implement

Comments

@octos
Copy link
Contributor

octos commented Aug 3, 2019

Use case

I just noticed that the Lyrics plugin fails to fetch lyrics to CHVRCHΞS songs because the artist name contains a Greek uppercase Xi (Ξ), whereas musixmatch.com and lyrics.wikia.com URLs are presumably limited to ASCII characters.

lyrics: failed to fetch: http://lyrics.wikia.com/Chvrch%CE%BEs:Forever (404)
lyrics: failed to fetch: https://www.musixmatch.com/lyrics/Chvrch%CE%BEs/Forever (404)

Solution

One solution would be for the Lyrics plugin to cycle through the artist’s MuzicBrainz aliases if it hits a 404 error.

See also

https://discourse.beets.io/t/asciiized-filenames-for-fetching-lyrics/855

@sampsyo sampsyo changed the title ASCIIized filenames for fetching lyrics (MusicBrainz aliases) lyrics: Use MusicBrainz artist aliases if default query is not found Aug 3, 2019
@sampsyo sampsyo added the feature features we would like to implement label Aug 3, 2019
@sampsyo
Copy link
Member

sampsyo commented Aug 3, 2019

Sounds good! It's worth noting that the plugin already does a few things like this for normalizing typography, but using the MB aliases would be a good idea too.

@Moonbase59
Copy link

Moonbase59 commented Sep 18, 2019

Now that is an interesting example, since I also have a Churches album. I mainly use Picard for tagging, and they have two interesting settings under Options → Metadata:

[x] Translate artist names to this locale when possible
[locale dropdown, I selected English, because I don’t read Japanese or Chinese]
[ ] Use standardized artist names

When I select "Translate", I get "CHVRCHES", when I switch it off, it stays "CHVRCHΞS".
Selecting "Use standardized" seems to change nothing (i.e., it stays "CHVRCHΞS").

Btw, (Album) Artist Sort Order seems always to keep whatever the editor put in "Sort name".

Since Picard is also in Python, it might be worth spelunking in their code to find out how they do it. Might improve compatibility. :-)

@hashhar
Copy link
Contributor

hashhar commented Apr 13, 2020

I think the better answer is using the sort fields since MusicBrainz encourages (or maybe enforces, not sure) using only ASCII for the sort fields to improve compatibility. And that is how they handle it in their source code too - they check for a transliteration if available, then fallback to the sort names.

If nobody is currently working on this, I can pick this up after I'm done with #3549.

Off-topic: @Moonbase59 Just in case you were wondering, the "Standardise artist names" means that Artists who get credited with different names on different releases. An example is https://musicbrainz.org/release/1cadc5d0-f4df-4341-aed9-0e33cdc38a72/details which is listed as Release by M.C. Sar & The Real McCoy but it changes to Real McCoy when the config is enabled.

Also, nice to see fellow CHVRCHES fans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants