@@ -340,11 +340,12 @@ def _start_server(self) -> bool:
340
340
return True
341
341
342
342
if (port := self .create_release_server_port ) == 0 :
343
+ # Find a free port for us to use. The OS will select a random available one.
344
+ # We can't pass 0 to waitress.create_server directly, this won't work when
345
+ # using hostnames instead of IP addresses for
346
+ # create_release_server_hostname, waitress will then bind to multiple
347
+ # sockets, with different ports for each.
343
348
with socket .socket () as s :
344
- # Find a free port for us to use. The OS will select a random available one.
345
- # We can't pass 0 to waitress.create_server directly, this won't work when
346
- # using hostnames instead of IP addresses for create_release_server_hostname,
347
- # waitress will then bind to multiple sockets, with different ports for each.
348
349
s .bind ((self .create_release_server_hostname , 0 ))
349
350
port = s .getsockname ()[1 ]
350
351
@@ -359,7 +360,8 @@ def _start_server(self) -> bool:
359
360
return True
360
361
except (PermissionError , ValueError , OSError ) as e :
361
362
self ._log .error (
362
- f"Failed to start internal web server on { self .create_release_server_hostname } :{ port } : { str (e )} "
363
+ f"Failed to start internal web server on "
364
+ f"{ self .create_release_server_hostname } :{ port } : { str (e )} "
363
365
)
364
366
self ._server = None
365
367
return False
0 commit comments