Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave parameter (un)packing for more than one wave has a very strange edge case #23

Open
beanieaxolotl opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working GAX (un)packer Regarding the GAX unpacker/packer help wanted Extra attention is needed

Comments

@beanieaxolotl
Copy link
Owner

beanieaxolotl commented Nov 13, 2024

In Action Man: Robot Atak, Both wave parameters in instrument 7 have out-of-bounds loop points and other corrupted parameters. This is a debug output of the wave parameters of this instrument, slightly formatted for clarity:

{'finetune': 0, 'modulate': False, 'ping_pong': True, 'start_position': 0, 
'loop_start': 1940, 'loop_end': 4640, 'modulate_size': 0, 'modulate_step': 0, 'modulate_speed': 0}

{'finetune': -252, 'modulate': True, 'ping_pong': True, 'start_position': 0, 
'loop_start': 255, 'loop_end': 7, 'modulate_size': 255, 'modulate_step': 14, 'modulate_speed': 0}]

Obviously, multiple wave params were not tested thoroughly as most of my research hinged on instruments that have only one wave param (i.e most of Martin Schioeler's tracks).

@beanieaxolotl beanieaxolotl added bug Something isn't working GAX (un)packer Regarding the GAX unpacker/packer labels Nov 13, 2024
@beanieaxolotl beanieaxolotl self-assigned this Nov 13, 2024
@beanieaxolotl beanieaxolotl changed the title Wave parameter unpacking for more than one wave is broken Wave parameter (un)packing for more than one wave is broken Nov 13, 2024
@beanieaxolotl
Copy link
Owner Author

Okay this is pretty weird: In the actual ROM, instrument 7 calls for two waveforms in two wave slots, but only one wave parameter is saved.

I used Mesen for this screenshot:

image

@beanieaxolotl beanieaxolotl changed the title Wave parameter (un)packing for more than one wave is broken Wave parameter (un)packing for more than one wave has a very strange edge case Nov 13, 2024
@beanieaxolotl beanieaxolotl added the help wanted Extra attention is needed label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GAX (un)packer Regarding the GAX unpacker/packer help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant