Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base URL parameter to AOSmithAPIClient Constructor #6

Open
AlanLivingston opened this issue Dec 27, 2024 · 0 comments
Open

Add Base URL parameter to AOSmithAPIClient Constructor #6

AlanLivingston opened this issue Dec 27, 2024 · 0 comments

Comments

@AlanLivingston
Copy link

Hi Brandon,

I noticed AO Smith changed the server again so that r2.wh8.co returns LOW, MEDIUM, HIGH for water status, and r1.wh8.com returns the numerical values. I saw that you changed py-aosmith to parse the hot water status as they change servers.

I've implemented a change that takes a base URL parameter in the AOSmithAPIClient constructor allowing users of py-aosmith to specify the server to use, and uses API_BASE_URL if nothing is specified. My motivation is to allow the server change in HAOS using a setting in configuration.yaml, but I don't have that working yet.

Let me know if you think this is worthwhile pursuing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant