Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictionary word length should be dynamic #28

Open
agronv opened this issue Sep 30, 2019 · 0 comments
Open

dictionary word length should be dynamic #28

agronv opened this issue Sep 30, 2019 · 0 comments

Comments

@agronv
Copy link

agronv commented Sep 30, 2019

I noticed that the word length in a dictionary is restricted to 1000 characters. Is there a reason why the word length is restricted? Wouldn't it be better if we allow the user to decide the word length like so

calculate_entropy(use_dictionary: false, min_word_length: 4, extra_dictionary_words: [], extra_words_limit = EXTRA_WORDS_LIMIT)
      extra_dictionary_words.collect! { |w| w[0...extra_words_limit] }
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant