Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password variants #27

Open
agronv opened this issue Sep 30, 2019 · 0 comments
Open

password variants #27

agronv opened this issue Sep 30, 2019 · 0 comments

Comments

@agronv
Copy link

agronv commented Sep 30, 2019

I noticed that the reverse of a password is not included in all the variants of a password.

# Returns all variants of a given password including the password itself
def self.all_variants(password)
      passwords = [password.downcase]
      passwords += keyboard_shift_variants(password)
      passwords += leet_speak_variants(password)
      passwords.uniq
end

shouldn't something like passwords += [password.downcase.reverse] be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant