Undefined variable $value

[da411d]

CodeIgniter/system/libraries/Cache/drivers/Cache_redis.php

Line 166 in 3658d73

if ($value !== FALSE && $this->_redis->sIsMember('_ci_redis_serialized', $key))

[jamieburchell]

Maybe @exussum12 knows

I can't figure out what this is supposed to be doing as the code it replaces returned the unserialized value in that case.

[exussum12]

Looks like it was refactored

                $value = $this->_redis->get($key);

		if ($value !== FALSE && $this->_redis->sIsMember('_ci_redis_serialized', $key))
		{
			return unserialize($value);
		}

Was the original. It was there for backwards compatibility between versions. There used to be a key in redis which stored all other keys, that made redis slow for large caches.

The current code (without any testing) looks like it will have the same issue of scaling for large caches.

Happy to remove the value (as its never used) though would check it scales with 1m cache entries for example

[jamieburchell]

I think how it was before this merge makes most sense, but I don't have any experience with this code and don't use Redis myself.

[exussum12]

The PR which was merged

https://github.com/bcit-ci/CodeIgniter/pull/5752/files

The context around where that PR came from

#5739

The context of the PR, I think all of the code which interacts with _ci_redis_serialized can be removed - it looks like BC between versions and will have been long enough now to now have an issue with removing it